Allow expressions in Nodes state_initial and state_final parameters

[daschw]

Fix #63
Fix #70

Thanks to Diana for providing the test example.

[daschw]

I just saw now that this might conflict with #69 so feel free to ignore and close

[sstroemer]

Looks good, thanks a lot!

I did some small changes to use some internal functionality for the isnothing checks - however I'm not sure if that works as is since I only edited it in and couldn't test (sorry).

[sstroemer]

Ah and regarding #69 (which I feel like is just an experimental draft), this one here is definitely the important one and I'd rather get this merged and then figure out the other one. So feel free to merge this one here. We should trigger new releases after that for core and the wrapper right?

[daschw]

Any idea why the tests are not running? Did we reach our monthly limit?

[sstroemer]

Any idea why the tests are not running? Did we reach our monthly limit?

I fear that is just misconfigured in the workflow. I think these settings do not trigger on adding commits, etc.

[sstroemer]

And the workflow_dispatch only allows manually running it on branches or tags...

[daschw]

I see, so I'd have to request a review for the tests to start? Anyway, I'm testing your suggestions locally now.

[sstroemer]

I see, so I'd have to request a review for the tests to start? Anyway, I'm testing your suggestions locally now.

Yes, seems to work - maybe a bit of a workaround, but maybe it's not that bad of an idea overall (I initially disabled the "on push" trigger because it would otherwise re-run the tests for every commit that you add, which could be more often then we'd like to).

[codecov]

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes missing coverage. Please review.

Project coverage is 48.81%. Comparing base (463763b) to head (7a4f3b0).
Report is 8 commits behind head on main.

Files with missing lines	Patch %	Lines
src/core/node.jl	66.66%	3 Missing ⚠️

@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
+ Coverage   48.28%   48.81%   +0.53%     
==========================================
  Files         111      112       +1     
  Lines        4548     4560      +12     
==========================================
+ Hits         2196     2226      +30     
+ Misses       2352     2334      -18     

Files with missing lines	Coverage Δ
src/core/node/con_first_state.jl	100.00% <100.00%> (ø)
src/core/node/con_last_state.jl	88.88% <100.00%> (+7.40%)	⬆️
src/core/node/var_state.jl	100.00% <100.00%> (ø)
src/parser.jl	83.45% <100.00%> (+1.60%)	⬆️
src/core/node.jl	58.10% <66.66%> (+1.39%)	⬆️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.