feat: Enhance GitHub repository name handling#1600
Open
EwanTauran wants to merge 2 commits intomainfrom
Open
Conversation
…full GitHub URLs and normalize input by stripping URL prefixes. Update related validation messages for clarity.
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="backend/airweave/platform/configs/config.py">
<violation number="1" location="backend/airweave/platform/configs/config.py:186">
P2: Normalize repo_name should strip query/fragment parts from full URLs; otherwise `owner/repo?tab=readme` passes validation and becomes an invalid repo identifier.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| if v.lower().startswith(prefix): | ||
| v = v[len(prefix) :] | ||
| break | ||
| return v |
Contributor
There was a problem hiding this comment.
P2: Normalize repo_name should strip query/fragment parts from full URLs; otherwise owner/repo?tab=readme passes validation and becomes an invalid repo identifier.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At backend/airweave/platform/configs/config.py, line 186:
<comment>Normalize repo_name should strip query/fragment parts from full URLs; otherwise `owner/repo?tab=readme` passes validation and becomes an invalid repo identifier.</comment>
<file context>
@@ -171,6 +173,18 @@ class GitHubConfig(SourceConfig):
+ if v.lower().startswith(prefix):
+ v = v[len(prefix) :]
+ break
+ return v
+
@field_validator("repo_name")
</file context>
Suggested change
| return v | |
| return v.split("?", 1)[0].split("#", 1)[0] if isinstance(v, str) else v |
…e type hints for better clarity and maintainability. Ensure consistent return types across validators. Addresses mypy issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance GitHub repository name handling: update validation to accept full GitHub URLs and normalize input by stripping URL prefixes. Update related validation messages for clarity.
Summary by cubic
Accept full GitHub repository URLs in the repo field and normalize them to owner/repo. This reduces input errors and keeps configs consistent.
https://github.com/...andhttp://github.com/...; strips prefix and trailing slash to store owner/repo.Written for commit a83b362. Summary will update on new commits.