Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
hiddeco
force-pushed
the
fix/oauth-session-ttl-5min
branch
from
a01f5de to
7797147
Compare
hiddeco
force-pushed
the
fix/oauth-session-ttl-5min
branch
from
7797147 to
9dc40fb
Compare
hiddeco
force-pushed
the
fix/oauth-session-ttl-5min
branch
from
9dc40fb to
ec9aca1
Compare
Comment on lines
324
to
+354
| @@ -333,8 +351,7 @@ async def create_proxy_url( | |||
| Returns: | |||
| (proxy_url, proxy_expires, redirect_session_id) | |||
| """ | |||
| proxy_ttl = 1440 # 24 hours | |||
| proxy_expires = datetime.now(timezone.utc) + timedelta(minutes=proxy_ttl) | |||
| proxy_expires = RedirectSession.default_expires_at() | |||
felixschmetz
approved these changes
Mar 13, 2026
hiddeco
force-pushed
the
fix/oauth-session-ttl-5min
branch
from
ec9aca1 to
b2bbbf6
Compare
The init-session and redirect-session TTLs were 30 min and 24 h respectively — far longer than needed for an interactive OAuth flow. This tightens both to 5 minutes via each model's `default_expires_at()` static method, which `flow_service.py` now calls instead of computing inline `timedelta` values. The test suite is strengthened with bracket assertions that pin the 5-minute window, covering both the model helpers and the service methods that consume them. The fake flow service is updated to match the new TTL.
hiddeco
force-pushed
the
fix/oauth-session-ttl-5min
branch
from
b2bbbf6 to
6b9ffa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The init-session and redirect-session TTLs were 30 min and 24 h respectively — far longer than needed for an interactive OAuth flow. This tightens both to 5 minutes via each model's
default_expires_at()static method, whichflow_service.pynow calls instead of computing inlinetimedeltavalues.The test suite is strengthened with bracket assertions that pin the 5-minute window, covering both the model helpers and the service methods that consume them. The fake flow service is updated to match the new TTL.