atdml: support <ocaml attr=...> on record fields, variant constructors, and payloads#498
Open
pedrobslisboa wants to merge 1 commit intoahrefs:masterfrom
Open
atdml: support <ocaml attr=...> on record fields, variant constructors, and payloads#498pedrobslisboa wants to merge 1 commit intoahrefs:masterfrom
pedrobslisboa wants to merge 1 commit intoahrefs:masterfrom
Conversation
Collaborator
|
Looks good to me, thanks! I fixed the merge conflict on the changelog. |
Collaborator
|
dlang.org is down, giving us an error on these lines: Looking into using the ubuntu package instead (#499) |
Collaborator
|
Hmm. I'll let you rebase against the |
8e3e781 to
1240e3a
Compare
bb586c6 to
3c3e878
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the ocaml attr annotation in three new positions in atdml: record fields, variant constructors, and variant payload types.
Type-definition-level attr ([@@attr]) was already supported; this extends it to the three remaining ATD positions.
Test plan:
🤖 Generated with Claude Code