Add custom metrics to micrometer#479
Open
qligier wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds Matchbox-specific Micrometer metrics and wires them into key validation/transformation endpoints, plus exposes gauges for cached engines and installed ImplementationGuides.
Changes:
- Introduces
MatchboxMetrics(counters + timer) and a SpringMatchboxMetricsConfigto register meters/gauges. - Increments validation/transformation counters from
$validate, Gazelle validation, and$transform, and records validation duration. - Extends
MatchboxImplementationGuideProviderwithcount()and implements it in R4/R4B/R5 IG providers; imports the metrics config in the main Spring application.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| matchbox-server/src/main/java/ch/ahdis/matchbox/validation/gazelle/GazelleValidationWs.java | Increments validation metric on Gazelle validation endpoint |
| matchbox-server/src/main/java/ch/ahdis/matchbox/validation/ValidationProvider.java | Increments validation metric and records validation duration |
| matchbox-server/src/main/java/ch/ahdis/matchbox/util/metrics/MatchboxMetrics.java | New metrics holder (counters + timer) |
| matchbox-server/src/main/java/ch/ahdis/matchbox/packages/MatchboxImplementationGuideProvider.java | Adds count() API for installed IGs |
| matchbox-server/src/main/java/ch/ahdis/matchbox/packages/ImplementationGuideProviderR5.java | Implements count() |
| matchbox-server/src/main/java/ch/ahdis/matchbox/packages/ImplementationGuideProviderR4B.java | Implements count() |
| matchbox-server/src/main/java/ch/ahdis/matchbox/packages/ImplementationGuideProviderR4.java | Implements count() |
| matchbox-server/src/main/java/ch/ahdis/matchbox/mappinglanguage/StructureMapTransformProvider.java | Increments transformation metric on $transform |
| matchbox-server/src/main/java/ch/ahdis/matchbox/config/MatchboxMetricsConfig.java | New config registering gauges and MatchboxMetrics bean |
| matchbox-server/src/main/java/ca/uhn/fhir/jpa/starter/Application.java | Imports MatchboxMetricsConfig |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.