-
Notifications
You must be signed in to change notification settings - Fork 9
Add watchdog_interval method
#11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
agis
merged 13 commits into
agis:master
from
Mr0grog:6-sdnotify-knows-your-watchdog-interval-but-will-it-tell-you
Oct 26, 2025
Merged
Changes from 5 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ef7c0be
Add `watchdog_interval` method and tests
Mr0grog 131eaee
Add watchdog example to README
Mr0grog 4644653
Update Rubocop config for current Rubocop
Mr0grog 744ac7d
Oops, I missed the separate Ruby 2.2 job
Mr0grog 22940b4
`positive?` does not exist in Ruby 2.2
Mr0grog f7901d7
Remove Rubocop, per review
Mr0grog 57b22fb
Return `nil` if no interval is set, per review
Mr0grog effcca9
Test truthiness, not boolean-ness, per review
Mr0grog 312c26f
Fix typo in README example
Mr0grog 2c4dd9c
Use supported runner for old Ruby, test current Ruby
Mr0grog 08014b5
It turns out we can not longer test on Ruby 2.2
Mr0grog 9ff9cdc
Try an older Minitest version
Mr0grog 20b1483
Fix test on Ruby 2.1
Mr0grog File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given how many cops I had to turn off in this PR, it might be better to disable them all here and explicitly turn on the ones you want. I’m not sure which you want, though, so I just turned off all the new and/or error-triggering ones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the issue is that rubocop was never pinned to a specific version. I'd suggest to just disregard all the offenses, given that it's not a requirement in the CI, and just revert this change here, since it's out of context of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, would it be good to at least remove this Rubocop config file, then? It seems a little confusing to have an unusable
.rubocop.ymlfile here.