Add TODO comment for rules_tf patch removal#753
Merged
agentydragon merged 1 commit intodevelfrom Mar 1, 2026
Merged
Conversation
Link yanndegat/rules_tf#28 so we know to remove the patches once the fix is upstreamed. https://claude.ai/code/session_014ZBAiyeychPb2xrP1kJPZ4
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a TODO in MODULE.bazel to track the eventual removal of locally-applied rules_tf patches once the corresponding upstream fix is available.
Changes:
- Added a TODO comment linking to the upstream
rules_tfPR that should enable patch removal.
Comments suppressed due to low confidence (1)
MODULE.bazel:40
- The TODO condition is a bit ambiguous: the PR being merged upstream doesn’t necessarily mean the fix is available in the released
rules_tfversion you depend on. Consider wording this as “once PR #28 is merged and released (i.e., after bumpingrules_tfto a version that contains the fix)” to avoid removing patches too early.
# TODO: remove patches once https://github.com/yanndegat/rules_tf/pull/28 is merged
agentydragon
added a commit
that referenced
this pull request
Mar 1, 2026
Link yanndegat/rules_tf#28 so we know to remove the patches once the fix is upstreamed. https://claude.ai/code/session_014ZBAiyeychPb2xrP1kJPZ4 Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds a TODO comment to document a pending patch removal for the
rules_tfdependency.Summary:
Added a TODO comment referencing the upstream pull request that, once merged, will allow the removal of the current patches applied to the
rules_tfmodule.Key changes:
Details:
The comment clarifies that the patches are a temporary workaround for an issue in the upstream
rules_tfrepository where transient registry outages can produce incomplete mirrors that Bazel caches, causing validation test failures. Once the referenced upstream PR is merged, these patches should no longer be necessary.https://claude.ai/code/session_014ZBAiyeychPb2xrP1kJPZ4