Merged
Conversation
- bash-init.sh: quote $(printf) in LESS_TERMCAP assignments
- build.sh: quote ${DESKTOP_TAG} and ${MCP_TAG} in docker commands
- entrypoint.sh: quote $RESOLUTION in vncserver -geometry
https://claude.ai/code/session_01TVjKdv6UebLZt9FP7ZuAbt
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes ShellCheck-relevant quoting issues in a few shell scripts to prevent unintended word splitting and make argument/env-var handling more robust.
Changes:
- Quote
$(printf ...)expansions used inLESS_TERMCAP_*environment variable assignments for coloredmanoutput. - Quote Docker tag variables in
docker build/docker pushinvocations. - Quote the VNC
-geometryargument derived from$RESOLUTION.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| nix/home/shell/bash-init.sh | Quotes printf command substitutions in LESS_TERMCAP_* env assignments within the man() wrapper. |
| cluster/k8s/agents/devbot/docker/desktop/entrypoint.sh | Quotes $RESOLUTION when passed to vncserver -geometry. |
| cluster/k8s/agents/devbot/docker/build.sh | Quotes ${DESKTOP_TAG} / ${MCP_TAG} in Docker build/push commands. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bash-init.sh: quote$(printf)in LESS_TERMCAP assignmentsbuild.sh: quote${DESKTOP_TAG}and${MCP_TAG}in docker commandsentrypoint.sh: quote$RESOLUTIONin vncserver-geometrySplit out from #1085 (shellcheck) so the code fixes land independently of the tooling setup.
Test plan
https://claude.ai/code/session_01TVjKdv6UebLZt9FP7ZuAbt