fix(ComboBox): avoid extra onSelectionChange calls

[reidbarber]

Closes #9727

Before:

• Selecting an option fired onSelectionChange once (expected)
• Clicking away fired it one extra time
• Tabbing away fired it two extra times

After:

• No extra onSelectionChange calls occur when values are already in sync

✅ Pull Request Checklist:

• Included link to corresponding React Spectrum GitHub Issue.
• Added/updated unit tests and storybook for this change (for new code or code which already has tests).
• Filled out test instructions.
• Updated documentation (if it already exists for this component).
• Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Unit tests should cover, but smoke test in storybook.

🧢 Your Project:

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the S2 docs
• View the React Aria docs

[LFDanLu]

doing some testing still, but do you know if this was a regression? Feels like didn't use to happen...

EDIT: has been happening since last Feb at least, so probably not a regression

[snowystinger]

is this still true if it allows a custom value?

[LFDanLu]

I think useComboBoxState will still clear the selected key on field blur via

react-spectrum/packages/@react-stately/combobox/src/useComboBoxState.ts

Line 422 in a6e720d

commitValue();

still

[LFDanLu]

I think these changes are fine after walking through it, but will need to do some careful testing.

[LFDanLu]

Decided to post this for others walking this logic for this change:
commitSelection is only called in these cases:

• when revert is called aka pressing Esc, which should revert the inputValue and make sure the selectedKey doesn't change
• when inputValue === itemText in the allowCustomValue case of commitValue of which results in a no-op except for multiple selection mode which we don't really support anyways
• conversely, used to reset the inputValue and close the menu in commitValue if allowCustomValue is false. This is only actually called as .close or if the menu is already closed and we are committing the value
• as a part of commit if we are selecting an already selected key

of those cases, we only really need to fire the onSelectionChange and onChange for the last two cases which seems to check out with new conditions here. The only one I'm not entirely sure is the selectionMode === 'multiple' part of the check, do we really need that? It might not hurt to have it I guess since it would simply call it for an extra case where inputValue === itemText but that is only when inputValue = '' since selectedKey is always null for multiple selection

[rspbot]

Build successful! 🎉

• View the storybook
• View the S2 storybook
• View the S2 docs
• View the React Aria docs