Skip to content

fix: CMD + arrows should not navigate RAC Tabs as it's a browser shortcut #9650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zdog1206 wants to merge 6 commits into
base: main
Choose a base branch
from
+99 −7
Open

fix: CMD + arrows should not navigate RAC Tabs as it's a browser shortcut #9650

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
abaf57c
Update useSelectableCollection.ts
Zdog1206 Feb 12, 2026
ceee89e
Update useSelectableCollection.ts
Zdog1206 Feb 12, 2026
8e123ac
Merge branch 'main' into Open-source-Contribution
snowystinger Mar 18, 2026
f753610
scope down the behaviour
snowystinger Mar 18, 2026
4edc370
simplify
snowystinger Mar 18, 2026
bbe8e6c
add stop propagation to appropriate key handlers
snowystinger Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/@react-aria/selection/src/useSelectableCollection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ export function useSelectableCollection(options: AriaSelectableCollectionOptions
}
};

if (manager.selectionMode === 'single' && (e.metaKey || e.altKey)) {
Copy link
Member

@snowystinger snowystinger Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is close, but it's going to affect too many things. I think it should be restricted to Left/Right arrows OR handling should be moved to the Tab's keyboard delegate.
Otherwise it may interfere with some of our selectionMode+selectionBehaviour https://react-aria.adobe.com/ListBox#selection

It looks like Up/Down + meta scrolls the entire page or moves the text cursor to the start or end of an input. I think in Tabs it shouldn't do anything. Much like the Toolbar in this github comment box.

return;
}

switch (e.key) {
case 'ArrowDown': {
if (delegate.getKeyBelow) {
Expand Down