Merged
Conversation
nikola-jokic
requested review from
mumoshu,
rentziass and
toast-gear
as code owners
Contributor
|
Hello! Thank you for your contribution. Please review our contribution guidelines to understand the project's testing and code conventions. |
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the 0.14.0 release across docs, Helm charts, and chart publishing automation for the autoscaling runner scale set controller ecosystem.
Changes:
- Add
0.14.0changelog entry to the controller docs. - Bump chart
version/appVersionto0.14.0for stable + experimental charts. - Extend the chart publishing workflow to optionally publish the experimental charts.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/gha-runner-scale-set-controller/README.md | Adds 0.14.0 release notes to the changelog section. |
| charts/gha-runner-scale-set/Chart.yaml | Bumps chart and app versions to 0.14.0. |
| charts/gha-runner-scale-set-experimental/Chart.yaml | Bumps chart and app versions to 0.14.0. |
| charts/gha-runner-scale-set-controller/Chart.yaml | Bumps chart and app versions to 0.14.0. |
| charts/gha-runner-scale-set-controller-experimental/Chart.yaml | Bumps chart and app versions to 0.14.0. |
| .github/workflows/gha-publish-chart.yaml | Adds workflow_dispatch inputs + jobs to publish experimental charts. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Prepares the repository for the 0.14.0 release by bumping Helm chart versions, updating the docs changelog, and extending CI/publishing automation and tests for the experimental charts.
Changes:
- Bump Helm chart
version/appVersionto0.14.0across stable and experimental charts. - Add/adjust chart tests (Go + helm-unittest YAML) for experimental charts and run them in the chart validation workflow.
- Extend the chart publishing workflow to optionally publish the new experimental charts.
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/gha-runner-scale-set-controller/README.md | Adds 0.14.0 changelog entry. |
| charts/gha-runner-scale-set/Chart.yaml | Bumps stable scale-set chart version/appVersion to 0.14.0. |
| charts/gha-runner-scale-set-experimental/Chart.yaml | Bumps experimental scale-set chart version/appVersion to 0.14.0. |
| charts/gha-runner-scale-set-controller/Chart.yaml | Bumps controller chart version/appVersion to 0.14.0. |
| charts/gha-runner-scale-set-controller-experimental/Chart.yaml | Bumps experimental controller chart version/appVersion to 0.14.0. |
| charts/gha-runner-scale-set-experimental/tests/template_test.go | New Go test asserting rendered resources use chart metadata labels/versions. |
| charts/gha-runner-scale-set-controller-experimental/tests/template_test.go | New Go test asserting rendered Deployment uses chart metadata labels/versions. |
| charts/gha-runner-scale-set-experimental/tests/manager_role_extra_rules_test.yaml | Updates helm-unittest setup to avoid hardcoding prior appVersion. |
| charts/gha-runner-scale-set-experimental/tests/manager_role_binding_labels_test.yaml | Updates helm-unittest assertions to avoid hardcoding prior chart/appVersion values. |
| charts/gha-runner-scale-set-experimental/tests/kube_mode_serviceaccount_test.yaml | Removes hardcoded chart appVersion in helm-unittest cases. |
| charts/gha-runner-scale-set-experimental/tests/kube_mode_role_test.yaml | Removes hardcoded chart appVersion in helm-unittest cases. |
| charts/gha-runner-scale-set-experimental/tests/kube_mode_role_binding_test.yaml | Removes hardcoded chart appVersion in helm-unittest cases. |
| charts/gha-runner-scale-set-experimental/tests/github_secret_labels_test.yaml | Updates helm-unittest assertions to avoid hardcoding prior version labels. |
| charts/gha-runner-scale-set-experimental/tests/autoscaling_runner_set_runner_pod_metadata_test.yaml | Updates helm-unittest assertions to avoid hardcoding prior version labels. |
| charts/gha-runner-scale-set-experimental/tests/autoscaling_runner_set_labels_test.yaml | Updates helm-unittest assertions to avoid hardcoding prior version labels. |
| .github/workflows/gha-validate-chart.yaml | Runs go test for both experimental chart trees in CI. |
| .github/workflows/gha-publish-chart.yaml | Adds inputs/jobs to publish experimental charts (but currently contains a version-extraction bug). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| - name: Publish new helm chart for gha-runner-scale-set-controller-experimental | ||
| run: | | ||
| echo ${{ secrets.GITHUB_TOKEN }} | helm registry login ghcr.io --username ${{ github.actor }} --password-stdin | ||
| GHA_RUNNER_SCALE_SET_CONTROLLER_CHART_VERSION_TAG=$(cat charts/gha-runner-scale-set-controller-experimental/Chart.yaml | grep version: | cut -d " " -d '"' -f 2) |
| run: | | ||
| echo ${{ secrets.GITHUB_TOKEN }} | helm registry login ghcr.io --username ${{ github.actor }} --password-stdin | ||
| GHA_RUNNER_SCALE_SET_CHART_VERSION_TAG=$(cat charts/gha-runner-scale-set-experimental/Chart.yaml | grep version: | cut -d " " -d '"' -f 2) |
rentziass
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Major changes