OcCryptoLib: Add Streebog support by lakreite · Pull Request #377 · acidanthera/OpenCorePkg

lakreite · 2022-08-04T11:23:08Z

Streebog support added into OcCryptoLib.

vit9696

Commented about most obvious issues with the code. There also are several codestyle issues with the code. Check https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/.

Include/Acidanthera/Library/OcCryptoLib.h

Library/OcCryptoLib/gost3411-2012-const.h

Library/OcCryptoLib/OcCryptoLib.inf

Library/OcCryptoLib/gost3411-2012-const.h

Library/OcCryptoLib/gost3411-2012-core.c

Utilities/TestStreebog/Makefile

Utilities/TestStreebog/StreebogPreprocess.c

Utilities/TestStreebog/Makefile

Utilities/TestStreebog/StreebogPreprocess.c

vit9696

CI is broken again, please fix. Also added more messages inline.

Include/Acidanthera/Library/OcCryptoLib.h

Library/OcCryptoLib/Streebog.c

Library/OcCryptoLib/Streebog.h

Utilities/TestStreebog/StreebogPreprocess.c

vit9696 · 2022-08-29T17:59:43Z

Utilities/TestStreebog/StreebogPreprocess.c

 #include <Library/OcCryptoLib.h>
 #include <BigNumLib.h>

+#define HASHSIZE 64


This must come from OcCryptoLib.h, not be defined here.

vit9696 · 2022-08-29T18:00:51Z

Library/OcCryptoLib/Streebog.c

- #elif defined (__BYTE_ORDER__) && __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
-  buf.QWORD[0] = BSWAP64 (CTX->bufsize << 3);
- #else
+#if (defined (__BYTE_ORDER__) && __BYTE_ORDER__ == __ORDER_LITTLE_ENDIAN__) || defined(MDE_CPU_IA32) || defined(MDE_CPU_X64)


Please introduce separate macros STREEBOG_LITTLE_ENDIAN and STREEBOG_BIG_ENDIAN in Streebog.h to reduce the length.

PMheart · 2022-10-13T18:31:12Z

Library/OcCryptoLib/Streebog.c

+  STREEBOG_CONTEXT  *Context
+  )
+{
+  for (INT32 i = 0; i < 64; ++i) {


EDK-II convention follows the rule where variables are declared at the beginning of functions; the same idea follows throughout the code.

Also, for indices, UINTN is used.

PMheart · 2022-10-13T18:34:42Z

Include/Acidanthera/Library/OcCryptoLib.h


+VOID
+Streebog256Init (
+  STREEBOG_CONTEXT  *Context


IN and OUT specifiers are missing, for all.

PMheart · 2022-10-13T18:35:09Z

Library/OcCryptoLib/Streebog.c

+  CONST UINT32      digest_size
+  )
+{
+  UINT32  i;


Should be UINTN.

PMheart · 2022-10-13T18:38:35Z

Library/OcCryptoLib/Streebog.c

+  GOST34112012Cleanup (Context);
+  Context->digest_size = digest_size;
+
+  for (i = 0; i < 8; i++) {


Even though clear, is it better if a macro is assigned to the magic number8?

PMheart · 2023-03-12T09:24:34Z

@lakreite Hello! Is this PR still alive? If not, I can start working on this. Thanks!

UPDATE - Assuming the original author will not work on this; I will start it.

Cam396 · 2024-07-18T16:50:28Z

is this pull request ever going to get merged?

vit9696 · 2024-07-18T17:28:40Z

Well, currently the review comments are not addressed yet. If you are willing to pick it up and complete, you are gladly welcome ^_^

Cam396 · 2024-07-18T22:32:05Z

i could try but i would have to learn C

okocsis · 2024-07-23T14:08:24Z

i could try but i would have to learn C

Can I land a hand here?

vit9696 · 2024-07-23T14:21:18Z

Well, we do not mind, please start with fixing up the CI.

okocsis · 2024-07-23T15:50:15Z

Well, we do not mind, please start with fixing up the CI.

okie doke

Spoou

k哦

Spoou

OBJS += RsaDigitalSign.o BigNumMontgomery.o BigNumPrimitives.o BigNumWordMul64.o Sha2.o SecureMem.o Sha512AccelDummy.o Streebog.o

Spoou · 2025-03-15T07:52:27Z

User/Makefile

 	#
 	# OcCryptoLib targets.
 	#
-	OBJS    += RsaDigitalSign.o BigNumMontgomery.o BigNumPrimitives.o BigNumWordMul64.o Sha2.o SecureMem.o Sha512AccelDummy.o


OBJS += RsaDigitalSign.o BigNumMontgomery.o BigNumPrimitives.o BigNumWordMul64.o Sha2.o SecureMem.o Sha512AccelDummy.o Streebog.o

jackacc · 2025-11-25T02:15:40Z

Nvidia Legacy

GeForce 8400 GS, ION 2, GeForce 205, 210, G 210M, 305M, 310(M), 405
Quadro FX (380 LP, 380M), NVS (300, 2100M, 3100M)
GeForce 8100, 8200, 8300 mGPU / nForce 700a series, 8200M G
GeForce 9300, 9400 mGPU / nForce 700i series, 8200M G, 9100M, 9400M (G)
GeForce 320M
GeForce GTX (465, 470, 480, 480M)
Quadro 4000, 5000[M] , 6000

How to set up OC to drive Nvidia Legacy graphics cards

Android-Artisan · 2025-12-15T12:03:02Z

this pr took 3-4 years. dam

vit9696 reviewed Aug 9, 2022

View reviewed changes

vit9696 reviewed Aug 24, 2022

View reviewed changes

vit9696 reviewed Aug 29, 2022

View reviewed changes

PMheart reviewed Oct 13, 2022

View reviewed changes

Library/OcCryptoLib/Streebog.c

CONST UINT32 digest_size

)

{

UINT32 i;

Copy link

Member

PMheart Oct 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be UINTN.

PMheart reviewed Oct 13, 2022

View reviewed changes

PMheart force-pushed the master branch from 106c75f to 130e143 Compare March 12, 2023 09:23

PMheart force-pushed the master branch from 130e143 to 69cebfd Compare March 22, 2023 07:43

vit9696 force-pushed the master branch from f7cfc01 to 676f834 Compare May 1, 2023 17:55

PMheart force-pushed the master branch from 69cebfd to 435faa4 Compare September 29, 2023 21:21

PMheart force-pushed the master branch from eaab875 to f41844a Compare April 6, 2024 21:49

lakreite added 16 commits April 6, 2024 23:50

OcCryptoLib: Add Streebog support

3ced458

streebog support fixes v1

67271a3

streebog support fixes v2

b271206

streebog support fixes v3

b32abbb

streebog support fixes v4

c227f20

streebog support fixes v5

c71eae4

streebog support fixes v6

9b71475

streebog tests fixes v1

af94c94

uncrustify fixes

6de11ce

uncrustify fixes v2

952405c

uncrustify fixes v3

78b2365

uncrustify fixes v4

99dee8d

test fixes v1

06fb3f0

test fixes v2

f0012e2

build fix

06e75d7

test fix

4f822a5

lakreite and others added 10 commits April 6, 2024 23:50

test fix v2

06e11b9

OcCryptoLib fix

20954e5

CodeStyle fixes v1

6d318de

fix array size

7d9491c

fix CompareMem codestyle

80abeda

fix STREEBOG_CONTEXT_ name

4d6ab89

define UINT512 on a UINT64 array with 8 items

8a0e0ae

fix prototype param order

59ae16d

fix tool build

42629d7

temporarily revert Streebog len to UINT32

6b4b606

PMheart force-pushed the master branch from f41844a to 6b4b606 Compare April 6, 2024 21:50

wojtus89 approved these changes Dec 26, 2024

View reviewed changes

Spoou approved these changes Mar 15, 2025

View reviewed changes

Spoou suggested changes Mar 15, 2025

View reviewed changes

wojtus89 approved these changes Mar 30, 2025

View reviewed changes

Conversation

lakreite commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vit9696 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vit9696 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vit9696 Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

vit9696 Aug 29, 2022

Choose a reason for hiding this comment

Uh oh!

PMheart Oct 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PMheart Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

PMheart Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

PMheart Oct 13, 2022

Choose a reason for hiding this comment

Uh oh!

PMheart commented Mar 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Cam396 commented Jul 18, 2024

Uh oh!

vit9696 commented Jul 18, 2024

Uh oh!

Cam396 commented Jul 18, 2024

Uh oh!

okocsis commented Jul 23, 2024

Uh oh!

vit9696 commented Jul 23, 2024

Uh oh!

okocsis commented Jul 23, 2024

Uh oh!

Spoou left a comment

Choose a reason for hiding this comment

Uh oh!

Spoou left a comment

Choose a reason for hiding this comment

Uh oh!

Spoou Mar 15, 2025

Choose a reason for hiding this comment

Uh oh!

jackacc commented Nov 25, 2025

Uh oh!

Android-Artisan commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

lakreite commented Aug 4, 2022 •

edited

Loading

PMheart Oct 13, 2022 •

edited

Loading

PMheart commented Mar 12, 2023 •

edited

Loading