Update the example code in user-trophy-list.md#231
Open
fantasydr wants to merge 1 commit intoachievements-app:mainfrom
Open
Update the example code in user-trophy-list.md#231fantasydr wants to merge 1 commit intoachievements-app:mainfrom
fantasydr wants to merge 1 commit intoachievements-app:mainfrom
Conversation
fantasydr
commented
Feb 12, 2026
fantasydr
commented
- Fetch all title data when the total amount exceeds the call limit (100 titles per call for now).
- Add a hint for downloading data for the user's own account instead of "xelnia" in the example.
1. Fetch all data when the total amount exceeds the limit (100 titles per call for now). 2. Add a hint for downloading data for the user's own account instead of "xelnia" in the example.
|
@fantasydr is attempting to deploy a commit to the achievements-app Team on Vercel. A member of the Team first needs to authorize it. |
wescopeland
reviewed
Mar 3, 2026
| const { trophyTitles } = await getUserTitles(authorization, targetAccountId); | ||
|
|
||
| // Ensure all data is fetched when the totalItemCount exceeds the limit. | ||
| const allTitles: TrophyTitle[] = []; |
Member
There was a problem hiding this comment.
This also needs to be added to the example import block.
| const allTitles: TrophyTitle[] = []; | ||
| let offset = 0; | ||
| while (true) { | ||
| const { totalItemCount, trophyTitles } = await getUserTitles( authorization, targetAccountId, { offset }); |
Member
There was a problem hiding this comment.
This may be more readable:
Suggested change
| const { totalItemCount, trophyTitles } = await getUserTitles( authorization, targetAccountId, { offset }); | |
| const { totalItemCount, trophyTitles } = await getUserTitles( | |
| authorization, | |
| targetAccountId, | |
| { offset } | |
| ); |
Author
There was a problem hiding this comment.
Hi, sorry for the late reply! I was caught up with a few other projects in March. Just wanted to check on the merging process for this repo—should I go ahead and update the commit, or were you planning to make the updates on your end?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.