Factorize check LORIS directory (PR 4)#1401
Open
MaximeBICMTL wants to merge 7 commits intoaces:bids_staging_branchfrom
Open
Factorize check LORIS directory (PR 4)#1401MaximeBICMTL wants to merge 7 commits intoaces:bids_staging_branchfrom
MaximeBICMTL wants to merge 7 commits intoaces:bids_staging_branchfrom
Conversation
github-actions
bot
added
Language: Python
MaximeBICMTL
added
Category: Refactor
MaximeBICMTL
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #1393 (diff)
Description
In the
lib.configmodule, many functions get LORIS-specific directories and check their existence/permissions. There is a lot of repeated code here, that this PR factorizes. This PR also renames some electrophysiology-related configuration directory functions for better clarity (notablyeeg->ephyssince those are also used by MEG).