Fix ORM SQL integration test columns comparison#1398
Merged
Conversation
github-actions
bot
added
the
Language: Python
MaximeBICMTL
added
Category: Bug
MaximeBICMTL
added
Complexity: Trivial
cmadjar
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I was surprised to see that the integration tests are succeeding given that there are recent updates on the LORIS SQL schema that are not yet reflected in the LORIS Python ORM models. But it turns out there is a small bug in the integration test:
list_a.sort()is compared withlist_b.sort(), but.sort()sorts a list in-place and always returnsNone! The correct solution is to usesorted(list)which returns the sorted list.