BIDS MRI import integration test (PR 3-bis)#1392
Open
MaximeBICMTL wants to merge 6 commits intoaces:bids_staging_branchfrom
Open
BIDS MRI import integration test (PR 3-bis)#1392MaximeBICMTL wants to merge 6 commits intoaces:bids_staging_branchfrom
MaximeBICMTL wants to merge 6 commits intoaces:bids_staging_branchfrom
Conversation
d120e17 to
1b1d891
Compare
1b1d891 to
8696d87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on top of #1389 (diff)
Description
The PR this builds on heavily refactors the BIDS MRI import code, which is obviously a risky move. This PR adds an integration test for the BIDS MRI importer.
Dataset
The bids dataset used is one I made myself using the
DCC090_587630_V2Raisinbread DICOMs, and using theBidsGuesssuggestions provided bydcm2niixto arrange the files. This dataset need to be added to the testing imaging bucket for this PR to pass the new test.The dataset looks as follow:
Comparison to main
This PR targets the reworked importer instead of the original. It is because the original importer currently does not pass the tests. It seems to suffer from path joins as string concatenations issues (
sub-1234ses-456anatkind of issues...). And I honestly don't really want to go fix this kind of issues just to replace the whole code afterwards, especially since the import of bvals and bvecs also seems broken in the main code, as well as the import of MRI derivatives (but well, it does not work here either TBH, at least this PR provides a test dataset to implement it correctly in the future).