Delete unused deprecated Python code#1295
Draft
MaximeBICMTL wants to merge 1 commit intoaces:mainfrom
Draft
Conversation
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 20 days. |
MaximeBICMTL
force-pushed
the
delete_unused_deprecated_code
branch
from
a65ca6b to
c75b51c
Compare
Contributor
Author
|
Meh too lazy to fix the broken test for now. That test will be easily fixed once the BIDS importer is merged. |
MaximeBICMTL
added
the
Caveat for Existing Projects
MaximeBICMTL
added
the
Language: Python
MaximeBICMTL
force-pushed
the
delete_unused_deprecated_code
branch
from
c75b51c to
f4bca8b
Compare
MaximeBICMTL
force-pushed
the
delete_unused_deprecated_code
branch
from
f4bca8b to
1b1a23e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR deleted the deprecated and unused code in LORIS-MRI 27. This allows to reduce the amount of code to maintain and the depreciation warnings in CI. All removed code have
@deprecatedannotations that point to newer alternatives.Changelog
lib.database_lib.mri_scanner.lib.database_lib.mri_upload_db.lib.database_lib.notification.lib.database_lib.project_cohort_rel.lib.database_lib.session_db.lib.database_lib.site.lib.database_lib.tarchive.lib.database_lib.tarchive_series.lib.database_lib.visit_windows.lib.dicom_archive.lib.imaging_io.lib.imaging_upload.lib.log.lib.imaging.get_scanner_id.lib.session.lib.utilities.