Skip to content

Fix Helm chart values.yaml having github-container-registry as default imagePullSecret #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThoSap merged 7 commits into from
Apr 1, 2026
Merged

Fix Helm chart values.yaml having github-container-registry as default imagePullSecret #47

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7419bab
fix Helm chart `values.yaml` having `github-container-registry` as de…
ThoSap Apr 1, 2026
baa3b99
fix typo
ThoSap Apr 1, 2026
5dda779
test the generated Helm chart
ThoSap Apr 1, 2026
754edea
test should depend on quarkusAppPartsBuild for HelmTest
ThoSap Apr 1, 2026
5b1ee90
fix the Gradle configuration cache issue by lazily configuring Mockit…
ThoSap Apr 1, 2026
2500549
make the behavior of Quarkiverse Kubernetes/Helm more apparent
ThoSap Apr 1, 2026
53ce633
fix typo CRD_GROP -> CRD_GROUP
ThoSap Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions operator/src/main/kubernetes/kubernetes.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@ spec:
template:
spec:
affinity: {}
imagePullSecrets: [{}]
Copy link
Copy Markdown

@stplasim stplasim Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn’t this cause a Kubernetes validation issue? It renders the following in the Helm chart:

imagePullSecrets:
  - {}

Each imagePullSecrets entry is supposed to have a name property.

You could either:

  • Remove the field entirely if no secrets are needed.
  • Use an empty array as a placeholder

Copy link
Copy Markdown
Contributor Author

@ThoSap ThoSap Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not manage to fix the generated values.yaml file to not generate

app:
  imagePullSecrets:
    - {}

but I wrote a test that validates that this indeed works with the Kubernetes (at least with v1.34) API.

For K3s I can't select v1.35 yet.

In a follow-up PR I would like to add a CI test matrix that tests the operator against a range of still supported K8s versions.
It should build the image before the test matrix (without publishing it yet) and then install the Helm chart and validate that the deployment is up and running.

14 changes: 6 additions & 8 deletions operator/src/main/resources/application.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,12 @@ quarkus:
value: IfNotPresent
paths:
- (kind == Deployment).spec.template.spec.containers.(name == ${quarkus.kubernetes.name}).imagePullPolicy
image-pull-secrets:
property: imagePullSecrets
value-as-list: []
paths:
- (kind == Deployment).spec.template.spec.imagePullSecrets
description: Kubernetes image pull secrets to use if the OCI image is hosted on a private registry
resource-requests-cpu:
property: resources.requests.cpu
value: ${quarkus.kubernetes.resources.requests.cpu}
Expand All @@ -99,12 +105,6 @@ quarkus:
value: ${quarkus.kubernetes.resources.limits.memory}
paths:
- (kind == Deployment).spec.template.spec.containers.(name == ${quarkus.kubernetes.name}).resources.limits.memory
image-pull-secret:
property: imagePullSecret
value: ${quarkus.kubernetes.image-pull-secrets[0]}
paths:
- (kind == Deployment).spec.template.spec.imagePullSecrets[0].name
description: Kubernetes image pull secret to use if the OCI image is hosted on a private registry
affinity:
property: affinity
value-as-map: {}
Expand Down Expand Up @@ -149,8 +149,6 @@ quarkus:
version: ${quarkus.application.version}
add-version-to-label-selectors: false
image-pull-policy: IfNotPresent
image-pull-secrets:
- github-container-registry
replicas: 1
annotations:
"app.kubernetes.io/version": ${quarkus.application.version}
Expand Down