Skip to content

Fix: Prevent vertical shifting of #content on the Watch page when displaying the stream status overlay. on Watch page #4721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
IgorA100 wants to merge 8 commits into
base: master
Choose a base branch
from
+4 −1
Open

Fix: Prevent vertical shifting of #content on the Watch page when displaying the stream status overlay. on Watch page #4721

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8acba9b
Prevent vertical shifting of #content on the Watch page when displayi…
IgorA100 Mar 23, 2026
91a94d1
Added a link to the PR (watch.php)
IgorA100 Mar 23, 2026
e2d4b37
Update web/skins/classic/views/watch.php
IgorA100 Mar 27, 2026
8963f7c
Revert watch.php
IgorA100 Mar 27, 2026
d8ada88
Update MonitorStream.js
IgorA100 Mar 27, 2026
bbe1b6f
Update MonitorStream.js
IgorA100 Mar 27, 2026
4334f6d
Merge branch 'ZoneMinder:master' into patch-990359
IgorA100 Mar 30, 2026
0fef2f9
Merge branch 'ZoneMinder:master' into patch-990359
IgorA100 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions web/skins/classic/views/watch.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,6 +408,7 @@
?>
</ul>
</nav>
<div style="padding-right:1px; margin-right: -1px;"></div> <--! REQUIRED https://github.com/ZoneMinder/zoneminder/pull/4721 -->
Copy link

Copilot AI Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This introduces an anonymous empty spacer <div> with inline styles and magic numbers (1px / -1px), which is hard to understand and maintain. Consider giving it an id/class (and aria-hidden="true") and moving the styling into the skin CSS with a short explanation of what layout shift it prevents.

Suggested change
<div style="padding-right:1px; margin-right: -1px;"></div> <--! REQUIRED https://github.com/ZoneMinder/zoneminder/pull/4721 -->
<style>
/* Spacer prevents a 1px horizontal layout shift between the nav sidebar
* and the monitor wrapper when scrollbars appear/disappear in some browsers.
* See https://github.com/ZoneMinder/zoneminder/pull/4721
*/
.monitor-layout-spacer {
padding-right: 1px;
margin-right: -1px;
}
</style>
<div class="monitor-layout-spacer" aria-hidden="true"></div>

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Contributor Author

@IgorA100 IgorA100 Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@connortechnology
I'm not sure Copilot's comment is necessary; it would add a lot of unnecessary code.
Isaac, the final word is yours.

<div id="wrapperMonitor" class="container-fluid col">
<div id="monitor" class="monitor hidden-shift"
>
Expand Down
Loading