-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Feat: Using audio motion analyzer #4393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IgorA100
wants to merge
40
commits into
ZoneMinder:master
Choose a base branch
from
IgorA100:patch-435415
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 20 commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
bd56f17
Loading "nouislider" and "audioMotion-analyzer" (functions.php)
IgorA100 2e8ad4f
Added <audio-motion> (Monitor.php)
IgorA100 3a25c84
Merge branch 'master' into patch-435415
IgorA100 826c1e3
Update functions.php
IgorA100 c405832
Merge branch 'master' into patch-435415
IgorA100 524ab91
Added audio visualization
IgorA100 d130f49
Audiovisualization
IgorA100 e677f6a
Remove extra space
IgorA100 a958d83
Audiovisualization
IgorA100 10fb918
Remove extra space
IgorA100 c49b48e
Audiovisualization
IgorA100 1cf92b4
Style adjustments
IgorA100 82095fe
If we don't display the video, then display the information block on …
IgorA100 d9361ea
Fix parent
IgorA100 33b9b45
Add "#whatDisplayControl" (event.php)
IgorA100 79f7db1
Add $whatDisplay (event.php)
IgorA100 7992fa4
Add changeWhatDisplay() (event.js)
IgorA100 1af54ad
Creating a volume slider on the Montage page to simultaneously contro…
IgorA100 c4dcf84
Fix: Eslint
IgorA100 9122a15
Removed an unused constant
IgorA100 1a1c219
skin.js
IgorA100 89a9839
Merge branch 'ZoneMinder:master' into patch-435415
IgorA100 b4dc754
Fix: Eslint (MonitorStream.js)
IgorA100 291ebb8
Update skin.js
IgorA100 4786bb5
Feat: Run changeWhatDisplay() without refreshing the page (watch.js)
IgorA100 3765301
Set maxFPS=30 instead of 50 (audioMotionAnalyzer.js)
IgorA100 495e6e8
Update web/skins/classic/js/skin.js
IgorA100 b468fa7
Update web/skins/classic/views/event.php
IgorA100 f3a2910
Instead of audioMotion.play(), use audioMotion.init() (MonitorStream.js)
IgorA100 3a37569
Update web/skins/classic/views/watch.php
IgorA100 686fd09
Update web/skins/classic/views/montage.php
IgorA100 7b96060
Update web/skins/classic/views/event.php
IgorA100 bf2fe61
Declare constants (skin.js)
IgorA100 ce0fc7a
Update web/skins/classic/js/skin.js
IgorA100 6f8a124
We'll use $cspNonce (functions.php)
IgorA100 364de38
Load audioMotionAnalyzer.js only on Watch, Montage, and Event pages (…
IgorA100 025d9fc
Added translation for "OPTIONS_WHATTODISPLAY" en_gb.php
IgorA100 5c5c05d
Removed extra semicolons (watch.js)
IgorA100 c4bab6a
Merge branch 'ZoneMinder:master' into patch-435415
IgorA100 e694130
Merge branch 'ZoneMinder:master' into patch-435415
IgorA100 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This adds a new
WhatDisplaymonitor field in defaults and UI, but the PR doesn’t include a DB migration/update SQL indb/to add theMonitors.WhatDisplaycolumn. Without an update script, installs/upgrades will hit SQL/ORM errors when accessing$monitor->WhatDisplay(). Add adb/zm_update-*.sqlentry (and/or schema update) as part of this change.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want to break anything, so I didn't add the SQL migration to the code.
You need to add the following code:
ALTER TABLEMonitorsADDWhatDisplayenum('OnlyVideo','OnlyAudioVisualization','VideoAudioVisualization') NOT NULL DEFAULT 'OnlyVideo' AFTERDecoding;