Use ManuallyDrop from the maybe-dangling crate.#6
Closed
theemathas wants to merge 1 commit intoWaffleLapkin:masterfrom
Closed
Use ManuallyDrop from the maybe-dangling crate.#6theemathas wants to merge 1 commit intoWaffleLapkin:masterfrom
theemathas wants to merge 1 commit intoWaffleLapkin:masterfrom
Conversation
This fixes WaffleLapkin#5, because moving a maybe-dangling ManuallyDrop does not assert validity or ownership of its contents, which avoids an unsoundness. Note that using the maybe-dangling crate means that, if the ManuallyDrop in the standard library ever gets MaybeDangling semantics, then the maybe-danging crate will get updated to take advantage of that (e.g., getting niche optimizations), and this takecell crate can benefit from that update without any code changes. See https://docs.rs/maybe-dangling/0.1.2/maybe_dangling/struct.ManuallyDrop.html#differences-with-corememmanuallydrop
Owner
Well, I'd still need to update the dependency version ^^' |
Author
|
New users of takecell would automatically get the new version of maybe-dangling, assuming that maybe-dangling's updated version is semver-compatible. I think? |
Owner
|
Ur totally right, I forgot for a second about |
Author
|
The underlying issue has been fixed. See rust-lang/rust#155750 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #5, because moving a maybe-dangling ManuallyDrop does not assert validity or ownership of its contents, which avoids an unsoundness.
Note that using the maybe-dangling crate means that, if the ManuallyDrop in the standard library ever gets MaybeDangling semantics, then the maybe-danging crate will get updated to take advantage of that (e.g., getting niche optimizations), and this takecell crate can benefit from that update without any code changes.
See https://docs.rs/maybe-dangling/0.1.2/maybe_dangling/struct.ManuallyDrop.html#differences-with-corememmanuallydrop