Skip to content

[FIX] Ensure that the accessToken is set back to the original #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davidcollom wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[FIX] Ensure that the accessToken is set back to the original #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pkg/venafi/tpp/connector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,10 @@ func (c *Connector) RevokeAccessToken(auth *endpoint.Authentication) (err error)
}

if auth.AccessToken != "" {
// Take a copy of any existing c.accessToken
// and Restore after our Revoke for any existing calls
origToken := c.accessToken
defer func(){ c.accessToken = origToken}
c.accessToken = auth.AccessToken
statusCode, statusText, _, err := c.request("GET", urlResource(urlResourceRevokeAccessToken), nil)
if err != nil {
Expand Down
15 changes: 15 additions & 0 deletions pkg/venafi/tpp/connector_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,6 +412,21 @@ func TestBadAuthorizeToTPP(t *testing.T) {
}
}

func TestRevokeAccessToken(t *testing.T){
tpp, err := getTestConnector(ctx.TPPurl, ctx.TPPZone)
if err != nil {
t.Fatalf("err is not nil, err: %s url: %s", err, expectedURL)
}

err = tpp.Authenticate(&endpoint.Authentication{AccessToken: ctx.TPPaccessToken})
if err != nil {
t.Fatalf("err is not nil, err: %s", err)
}
tpp.RevokeAccessToken(&endpoint.Authentication{AccessToken: "RandomAccessToken"})
// Ensure that our own access token is set back!
assert.Equal(t, tpp.accessToken, ctx.TPPaccessToken)
}

func TestReadConfigData(t *testing.T) {
tpp, err := getTestConnector(ctx.TPPurl, ctx.TPPZone)
if err != nil {
Expand Down