Conversation
Adding a newline at the end of the file is a good practice
Correct the syntax so that it takes every line except the first
- Major changes: - Adopt new filtering method - Adjust genome and annotation extraction locations - Also apply filtering to bakta files - Quality-of-life changes: - Count genomes of species of interest - Add number of genomes in original & update - Add message about number of genomes table - Include header line in filtered metadata table - Coding practicalities: - Enable strict mode - Tidy up code
- Apply snakefmt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the past months, we have made a number of small improvements:
prepare_genomes.shscript to prevent overwriting batches