fix(ui5-textarea): set textarea wrapper padding in base theme file#13345
Open
aleksandar-terziev wants to merge 1 commit intomainfrom
Open
fix(ui5-textarea): set textarea wrapper padding in base theme file#13345aleksandar-terziev wants to merge 1 commit intomainfrom
aleksandar-terziev wants to merge 1 commit intomainfrom
Conversation
Collaborator
|
🚀 Deployed on https://pr-13345--ui5-webcomponents-preview.netlify.app |
nikoletavnv
reviewed
Apr 3, 2026
| --_ui5_textarea_focus_outline_color: var(--sapContent_FocusColor); | ||
| --_ui5_textarea_min_height: 2.25rem; | ||
| --_ui5_textarea_wrapper_padding: 0; | ||
| --_ui5_textarea_wrapper_padding: 0.0625rem; |
Contributor
There was a problem hiding this comment.
Once we set the padding in the base .css we should remove it from the horizon themes because it is redundant.
Remove the parameter --_ui5_textarea_wrapper_padding: 0.0625rem; from:
packages/main/src/themes/sap_horizon/TextArea-parameters.css and
packages/main/src/themes/sap_horizon_dark/TextArea-parameters.css
Contributor
Author
There was a problem hiding this comment.
Resolved!
aleksandar-terziev
force-pushed
the
text-area-padding
branch
from
9337989 to
21517e1
Compare
aleksandar-terziev
force-pushed
the
text-area-padding
branch
from
21517e1 to
40cc29f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #13343