Skip to content

fix(ui5-dialog): fix unwanted animation when opening with large content #13121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TeodorTaushanov merged 8 commits into from
Apr 8, 2026
+80 −0
Merged

fix(ui5-dialog): fix unwanted animation when opening with large content #13121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d9c7219
fix(ui5-dialog): fix unwanted animation when opening with large content
TeodorTaushanov Feb 19, 2026
f4c9f23
chore: fix indentation
TeodorTaushanov Feb 19, 2026
a654a4e
Merge remote-tracking branch 'origin/main' into dialog_opening_animation
TeodorTaushanov Mar 10, 2026
2c18d29
chore: add the example from the issue
TeodorTaushanov Mar 10, 2026
190bffd
Merge remote-tracking branch 'origin/main' into dialog_opening_animation
TeodorTaushanov Mar 25, 2026
0554702
chore: resolve merge conflicts
TeodorTaushanov Mar 25, 2026
f418a5e
Merge remote-tracking branch 'origin/main' into dialog_opening_animation
TeodorTaushanov Apr 8, 2026
4bb3807
chore: fix image src
TeodorTaushanov Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/main/src/Popup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,11 @@ abstract class Popup extends UI5Element {

this._addOpenedPopup();

this.classList.add("ui5-popup-opening");
setTimeout(() => {
this.classList.remove("ui5-popup-opening");
}, 50);

this.open = true;

// initial focus, if focused element is statically created
Expand Down
4 changes: 4 additions & 0 deletions packages/main/src/themes/Popup.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,8 @@

:host(:focus-visible) {
outline: none;
}

:host(.ui5-popup-opening) {
opacity: 0.1;
}
71 changes: 71 additions & 0 deletions packages/main/test/pages/Dialog.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,11 @@
<br>
<br>
<ui5-button id="native-dnd-open">Open draggable dialog with native DnD</ui5-button>
<br>
<br>
<ui5-button id="open-big-dynamic-content">Open dynamic dialog with big content</ui5-button>
<br>
<br>
</div>
<ui5-block-layer></ui5-block-layer>

Expand Down Expand Up @@ -1159,6 +1164,72 @@
const data = e.dataTransfer.getData("text");
dropZone.textContent = `Dropped: ${data}`;
});

document.getElementById("open-big-dynamic-content").addEventListener("click", function () {
const dialog = document.createElement("ui5-dialog");
const child1 = `
<div slot="header" design="Header">
<h3>Random Title</h3>
</div>
`;

const child2 = `
<div>
<div>
<div>
<div>
<div>
<img width="60" height="60" src="./img/man_avatar_1.png">
</div>
</div>
<div>
<div>Contact RANDOM CORP</div>
<div>Some subtitle</div>
</div>
</div>
</div>
<form>
<div>
<div>
<p>Subscribe to our newsletter</p>
<small>No spam, only updates.</small>
</div>
</div>
<div>
<small>Hint: Use a valid code</small>
</div>
<div>Your Info</div>
<div>
<div>
</div>
<div>
</div>
</div>
<div>Company Info</div>
<div>
<div>
</div>
<div>
</div>
</div>
<div></div>
<div>
<div>
<span>
I agree to the random terms and conditions.
Read Privacy Policy.
</span>
</div>
</div>
<div></div>
</form>
</div>
`;

dialog.innerHTML = child1 + child2;
document.body.appendChild(dialog);
dialog.open = true;
});
</script>
</body>

Expand Down
Loading