Skip to content

Migrate Hurl.BrowserSelector to WinUI3#174

Open
U-C-S wants to merge 34 commits intomainfrom
task/migrate-selector-winui
Open

Migrate Hurl.BrowserSelector to WinUI3#174
U-C-S wants to merge 34 commits intomainfrom
task/migrate-selector-winui

Conversation

@U-C-S
Copy link
Copy Markdown
Owner

@U-C-S U-C-S commented Nov 9, 2024

close #120, #106

@U-C-S U-C-S mentioned this pull request Feb 12, 2025
12 tasks
@U-C-S
Copy link
Copy Markdown
Owner Author

U-C-S commented Feb 27, 2025

Waiting on winappsdk 1.7 stable

@U-C-S
Copy link
Copy Markdown
Owner Author

U-C-S commented Apr 8, 2025

For trayicon: https://github.com/HavenDV/H.NotifyIcon

<PackageReference Include="Microsoft.Win32.Registry" Version="5.0.0" />
<PackageReference Include="Microsoft.Windows.CsWinRT" Version="2.2.0" />
<PackageReference Include="Microsoft.Windows.SDK.BuildTools" Version="10.0.26100.1742" />
<PackageReference Include="Microsoft.WindowsAppSDK" Version="1.6.250205002" GeneratePathProperty="true" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the new XAML TitleBar in 1.7.1

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread Source/Hurl.Selector/Hurl.Selector.csproj Outdated
Comment thread Source/Hurl.Selector/MainWindow.cs Outdated
Comment thread Source/Hurl.Selector/MainWindow.cs Outdated
Comment thread Source/Hurl.Selector/Pages/SelectorPage.xaml Outdated
Comment thread Source/Hurl.Selector/Pages/SelectorPage.xaml Outdated
<MenuFlyout>
<MenuFlyoutItem
Click="Button_Click_1"
Tag="settings"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tags don't match text


<Grid>
<Grid.RowDefinitions>
<RowDefinition Height="30" />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32 or Auto

Spacing="8">
<StackPanel
Padding="8"
Background="{StaticResource AccentAcrylicBackgroundFillColorBaseBrush}"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, use ThemeResource. Also use a central Style.

Background="{StaticResource AccentAcrylicBackgroundFillColorBaseBrush}"
BorderBrush="{StaticResource ControlElevationBorderBrush}"
BorderThickness="1.5"
CornerRadius="4"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use StaticResources

@U-C-S

This comment was marked as resolved.

@U-C-S U-C-S force-pushed the task/migrate-selector-winui branch from e19161f to 1a727af Compare April 5, 2026 18:22
@U-C-S U-C-S marked this pull request as ready for review April 12, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hurl Rewrite Project

2 participants