fix(coverage): ignore case comments and done redirections (#634)#635
Merged
Chemaclass merged 2 commits intomainfrom Apr 21, 2026
Merged
fix(coverage): ignore case comments and done redirections (#634)#635Chemaclass merged 2 commits intomainfrom
Chemaclass merged 2 commits intomainfrom
Conversation
Coverage counted `*pat) # comment` and loop terminators with redirections or pipes (`done < file`, `done <<<"$var"`, `done | sort`) as executable lines. Update is_executable_line regex to skip trailing comments on case patterns and treat `done` followed by `<`, `>`, `|` or `&` as a non-executable loop terminator. Closes #634
Widen the loop-terminator skip to match `done 2>&1`, `done &`, `done >>` and other non-space trailing forms. Regex now requires any non-space, non-comment char after `done ` so any valid trailing redirection, fd redirect, pipe or background marker keeps `done` non-executable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
*thing) # note) were counted as executable lines.done < file,done <<<"$var",done | sort,done < <(cmd)) were counted as executable lines.Fix
src/coverage.sh::bashunit::coverage::is_executable_line:(#.*)?on the case-pattern regex so*pat) # commentis recognized as non-executable.donefollowed by any of<,>,|,&as a non-executable loop terminator.Test plan
./bashunit tests/unit/coverage_executable_test.sh tests/unit/coverage_core_test.sh./bashunit tests/./bashunit --parallel tests/make samake lintget_executable_lineson a fixture with all patternsCloses #634