Various, minor, grammar changes and fixes #655
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on standardizing spelling conventions throughout the documentation, specifically converting American English spellings to British English variants. The changes are primarily in comments and documentation text rather than functional code.
- Converts American spellings to British equivalents (e.g., "optimization" → "optimisation", "visualization" → "visualisation")
- Removes duplicate words and fixes minor grammatical issues
- Updates package name references for consistency
Reviewed Changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| usage/tracking-extra-quantities/index.qmd | Changes "parameterization" to "parameterisation" |
| usage/sampler-visualisation/index.qmd | Removes duplicate "and" in HMC description |
| usage/mode-estimation/index.qmd | Updates "Optimization.jl" to "Optimisation.jl" references |
| usage/external-samplers/index.qmd | Changes "optimization" to "optimisation" and "initialization" to "initialisation" |
| usage/automatic-differentiation/index.qmd | Changes "optimization" to "optimisation" |
| tutorials/variational-inference/index.qmd | Multiple spelling changes and function renaming for consistency |
| tutorials/probabilistic-pca/index.qmd | Changes "visualization" to "visualisation" and removes duplicate "the" |
| tutorials/multinomial-logistic-regression/index.qmd | Changes "normalizing" to "normalising" and "Standardize" to "Standardise" |
| tutorials/bayesian-logistic-regression/index.qmd | Changes "normalizing" to "normalising" |
| tutorials/bayesian-linear-regression/index.qmd | Changes "visualization" to "visualisation" and "normalizing" to "normalising" |
| tutorials/bayesian-differential-equations/index.qmd | Changes "optimization" to "optimisation" |
| faq/index.qmd | Changes "vectorized" to "vectorised" |
| developers/inference/variational-inference/index.qmd | Changes "maximize" to "maximise" and "parameterization" to "parameterisation" |
| developers/inference/abstractmcmc-interface/index.qmd | Changes "parameterization" to "parameterisation" |
| core-functionality/index.qmd | Changes "Initialize" to "Initialise" and "visualization" to "visualisation" |
| README.md | Changes "License" to "Licence" and removes line break |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 34 out of 35 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
tutorials/probabilistic-pca/index.qmd:1
- Corrected spelling of 'coordinats' to 'coordinates'.
---
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 39 out of 40 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 39 out of 40 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Preview the changes: https://turinglang.org/docs/pr-previews/655 |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 40 out of 41 changed files in this pull request and generated no new comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mhauru
left a comment
There was a problem hiding this comment.
Broadly happy with this, a few requests.
| `mtcars` contains a variety of statistics on different car models, including their miles per gallon, number of cylinders, and horsepower, among others. | ||
|
|
||
| We want to know if we can construct a Bayesian linear regression model to predict the miles per gallon of a car, given the other statistics it has. | ||
| We want to know if we can construct a Bayesian linear regression model to predict the miles per gallon of a car, given the other statistics it possesses. |
There was a problem hiding this comment.
I find the original version of this, "has", clearer and easier to read. Do you have a reason for preferring "possesses"?
There was a problem hiding this comment.
Changed "possesses" back to "has"
| This is because we set the second parameter of the NUTS sampler (which is the number of adaptations) to be equal to 200. | ||
| The initial samples during the [warmup phase](https://en.wikipedia.org/wiki/Markov_chain_Monte_Carlo) show higher variability and should be discarded before computing posterior statistics. | ||
| Thus, we remove these warmup samples and view the diagnostics again. | ||
| We discard the first 200 samples, corresponding to the adaptation phase used by the NUTS sampler (specified via the `discard_adapt=false` argument above). |
There was a problem hiding this comment.
| We discard the first 200 samples, corresponding to the adaptation phase used by the NUTS sampler (specified via the `discard_adapt=false` argument above). | |
| We discard the first 200 samples, corresponding to the adaptation phase used by the NUTS sampler (which we explicitly chose not to discard earlier with `discard_adapt=false` argument). |
There was a problem hiding this comment.
Added clarification about the discard_adapt=false
| [JuliaGPs](https://github.com/JuliaGaussianProcesses/#welcome-to-juliagps) packages integrate well with Turing.jl because they implement the Distributions.jl | ||
| interface. | ||
| You should be able to understand what is going on in this tutorial if you know what a GP is. | ||
| This tutorial assumes familiarity with [Gaussian processes](https://en.wikipedia.org/wiki/Gaussian_process); for an introduction, see [Rasmussen and Williams (2006)](http://www.gaussianprocess.org/gpml/). |
There was a problem hiding this comment.
I feel like "familiarity" could mean a lot of things, from "roughly knows what a GP is" to "works in the field, eats GPs for breakfast". Could we specify a bit more? Especially if the answer is more like the former, in which case I wouldn't want to scare people away.
There was a problem hiding this comment.
Softened in latest commit
| </div> | ||
| <div class="footer-bottom"> | ||
| <p>Turing.jl was created by <a href="https://mlg.eng.cam.ac.uk/hong/" target="_blank" rel="noopener">Hong Ge</a>, and maintained by the core <a href="https://turinglang.org/team/" target="_blank" rel="noopener">team</a> of developers and <a href="https://github.com/TuringLang/Turing.jl/graphs/contributors" target="_blank" rel="noopener">contributors</a>.<br>© 2025 The Turing Project Contributors. <a href="https://github.com/TuringLang/Turing.jl/blob/master/LICENCE" target="_blank" rel="noopener">MIT License</a>.</p> | ||
| <p>Turing.jl was created by <a href="https://mlg.eng.cam.ac.uk/hong/" target="_blank" rel="noopener">Hong Ge</a>, and maintained by the core <a href="https://turinglang.org/team/" target="_blank" rel="noopener">team</a> of developers and <a href="https://github.com/TuringLang/Turing.jl/graphs/contributors" target="_blank" rel="noopener">contributors</a>.<br>© 2025 The Turing Project Contributors. <a href="https://github.com/TuringLang/Turing.jl/blob/master/LICENSE" target="_blank" rel="noopener">MIT License</a>.</p> |
There was a problem hiding this comment.
I'm confused by this one. https://github.com/TuringLang/Turing.jl/blob/master/LICENCE, the old link, seems to be correct, no?
There was a problem hiding this comment.
Lemme check, I realised in my haste to fix spellings that I broke a file / ref link so maybe I double corrected.
There was a problem hiding this comment.
Ping me for a rereview once you're done.
| # Turing.jl Documentation and Tutorials | ||
|
|
||
| **https://turinglang.org/docs/** | ||
| **https://turinglang.org/docs/** |
There was a problem hiding this comment.
Is this file just getting a lot of trailing whitespace added, or am I missing something?
There was a problem hiding this comment.
Thanks, I was having weird markdown rendering for me, so I assumed it was some kind of needing extra space. Fixed in last commit.
| ## License | ||
|
|
||
| This project is licensed under the MIT License - see the [LICENSE](LICENSE) file for details. | ||
| This project is licensed under the MIT License - see the [License](License) file for details. No newline at end of file |
There was a problem hiding this comment.
| This project is licensed under the MIT License - see the [License](License) file for details. | |
| This project is licensed under the MIT License - see the [License](LICENSE) file for details. |
The link breaks if the capitalisation doesn't match the filename.
There was a problem hiding this comment.
Fixed in commit about to be pushed once I finish replying to comments
This PR improves the documentation quality with various grammar and spelling fixes.
Changes
LICENCEtoLICENSEFiles affected
41 files across tutorials, usage guides, and developer documentation have been updated for consistency and clarity.