Conversation
There was a problem hiding this comment.
Thanks for figuring this out! Can you update the PR's description to match the last time we bumped the baseline in #5616 (I can do it tomorrow; today is a holiday in Greece)? You're fast. 😅
Can you also mention in the description the AWS SDK PR that fixed the issue?
| #error \ | ||
| "CAPNP_VERSION is not defined, is capnp/generated-header-support.h missing?" | ||
| #elif CAPNP_VERSION != 1002000 | ||
| #elif CAPNP_VERSION != 1003000 |
There was a problem hiding this comment.
Only that changed? That's nice.
|
aws/aws-sdk-cpp#3706 looks like the only relevant PR between the two versions. CI fails because Azurite needs to be updated. |
|
Thanks @teo-tsirpanis! It looks like we install azurite with Edit: Looking at CI logs it seems like we are using 3.35.0 which is the latest release, and unfortunately this doesn't support the latest Azure API. It seems others are setting |
The latest release of azurite does not fully support the latest azurite API specification. https://github.com/Azure/Azurite/releases
This reverts commit c803e77.
shaunrd0
force-pushed
the
shaunreed/cloud-3500-update-aws-sdk
branch
from
7afde48 to
e8e75cc
Compare
scripts/run-azurite.sh
Outdated
| --location /tmp/azurite-data \ | ||
| --debug /tmp/azurite-data/debug.log \ | ||
| --blobPort 10000 \ | ||
| --skipApiVersionCheck \ |
There was a problem hiding this comment.
I would prefer to update the Azure VFS' initialization code to specify API version 2025-11-05; this way it would be easier to notice in the future, after Azurite gets updated (Azure/Azurite#2629).
| .PageSizeHint = max_keys, | ||
| .StartFrom = {}}); |
There was a problem hiding this comment.
Why was this changed? Isn't {} the default already?
There was a problem hiding this comment.
CI reported a werror for this after the update
https://github.com/TileDB-Inc/TileDB/actions/runs/22310958792/job/64542632032#step:13:125
|
/backport to release-2.30 |
|
Started backporting to release-2.30: https://github.com/TileDB-Inc/TileDB/actions/runs/22324290208 |
…5757) Backport of #5756 to release-2.30 --- TYPE: BUILD DESC: Update vcpkg version baseline to microsoft/vcpkg@dd930e3. --------- Co-authored-by: Shaun Reed <shaunrd0@gmail.com>
3 participants
This bumps the vcpkg baseline commit to update the AWS SDK. Updating the AWS SDK was found to resolve BadDigest errors we are seeing running taskgraphs in CLOUD-3500.
To view the full list of updated ports, you can clone vcpkg and run
git diff 3b9d086009cc1c2256e9c28ad44a00036fbd9b26 dd930e314f529c86d2703a60d5ea7dd6573d9e5a -- ./versions/baseline.json > baseline.diff. This is an abridged summary of the updated ports that we depend on:TYPE: BUILD
DESC: Update vcpkg version baseline to microsoft/vcpkg@dd930e3.