Skip to content

Permit true-ASCII attributes in non-from-pandas dataframes #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nguyenv merged 4 commits into from
Oct 5, 2022
Merged

Permit true-ASCII attributes in non-from-pandas dataframes #1337

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aec302a
Permit true-ASCII attributes in non-from-pandas dataframes
johnkerl Oct 3, 2022
efb5008
code-review feedback
johnkerl Oct 4, 2022
4464b82
code-review feedback
johnkerl Oct 4, 2022
222f4e9
code-review feedback
johnkerl Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tiledb/libtiledb.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1534,6 +1534,7 @@ cdef class Attr(object):
if isinstance(dtype, str) and dtype == "ascii":
tiledb_dtype = TILEDB_STRING_ASCII
ncells = TILEDB_VAR_NUM
var = True
else:
_dtype = np.dtype(dtype)
tiledb_dtype, ncells = array_type_ncells(_dtype)
Expand Down