Codespell: Ignore URIs and emails#29830
Merged
rlmoser99 merged 1 commit intoTheOdinProject:mainfrom Jul 5, 2025
Merged
Conversation
Contributor
Author
|
I may have choked on my drink getting the notification of codespell false positive with files untouched by this PR, and some in URLs as well. What irony... |
rlmoser99
approved these changes
Jul 5, 2025
Member
rlmoser99
left a comment
There was a problem hiding this comment.
I agree, we should exclude URIs and emails from spell checker. Thanks for taking the time to make this change!
Contributor
|
Hey Mao, I think the codespell still isn't ignoring the archive folder, for the newer codespell run on PR #29831 |
rlmoser99
pushed a commit
that referenced
this pull request
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
Can't think of a situation where we actually want codespell to check URLs or emails. Example false flag of
crytoin a URL: #29814This PR
Issue
Closes #29815
Pull Request Requirements
location of change: brief description of changeformat, e.g.Intro to HTML and CSS lesson: Fix link textBecausesection summarizes the reason for this PRThis PRsection has a bullet point list describing the changes in this PRIssuesection