Merged
Conversation
2 tasks
GiJungPark
approved these changes
Mar 31, 2026
|
|
||
| private BooleanExpression checkGenres(List<Genre> genres) { | ||
| private BooleanExpression checkGenres(List<Genre> genres, boolean includeEtc) { | ||
| BooleanExpression etcCondition = includeEtc ? feed.novelId.isNull() : null; |
Member
There was a problem hiding this comment.
p5; 회사에서 하신 말씀이 이거였군요 ㅋㅎㅋㅎㅋㅎㅋ 진짜 햇갈리긴 하네요..
Member
There was a problem hiding this comment.
p5; 분기에 따라 Repository 호출하는 로직만 있다보니 행위 검증 테스트로 진행하셨군요!
Contributor
Author
There was a problem hiding this comment.
쿼리 dsl이 아직 익숙하지 않아서, 단위 테스트로 진행 해야 하는것들도 통합 테스트로 진행을 했습니다. 추후 개선할수 있으면 좋겠네요!
Member
There was a problem hiding this comment.
p5; 통합 테스트 확인했습니다!
얼른 단위 테스트 하나 하나 늘려서, 단위 테스트만으로 모든 검증이 가능하게 되어야겠네요...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Key Changes
To Reviewers
References