Skip to content

Docker build#3

Merged
ibn-salem merged 7 commits intodevfrom
docker-build
Oct 20, 2025
Merged

Docker build#3
ibn-salem merged 7 commits intodevfrom
docker-build

Conversation

@Tishwings
Copy link
Copy Markdown
Member

Hey, I prepared a new workflow for building the docker image.

I tested it and it created the image https://github.com/TRON-Bioinformatics/splice2neo/pkgs/container/splice2neo with the current release v0.6.13 as tag. Can be pulled with the command:

docker pull ghcr.io/tron-bioinformatics/splice2neo:v0.6.13

After testing I switched the trigger to release. The pipeline should now only run when a new release was published and the tag should always be the release tag.

@johausmann
❓I edited the syntax in the Dockerfile since docker buildx in github doesn't recognize the "docker://" prefix. Will this still work for your local build? When not, we need a second Dockerfile.
❓ Is "splice2neo" as name for the image ok or would something else be more suitable?

@johausmann
Copy link
Copy Markdown
Member

I edited the syntax in the Dockerfile since docker buildx in github doesn't recognize the "docker://" prefix. Will this still work for your local build? When not, we need a second Dockerfile.

I think this should not be a problem. If I remember correctly, we required this for the old docker version on our system.

Is "splice2neo" as name for the image ok or would something else be more suitable?

Name should be fine

@johausmann
Copy link
Copy Markdown
Member

@ibn-salem, can you please review the R-CMD check? I think this comes from the transition of the txdb function into a new R package

@ibn-salem
Copy link
Copy Markdown
Member

ibn-salem commented Sep 24, 2025

makeTxDbFromGFF() has moved from GenomicFeatures to the txdbmaker package,
  and is formally defunct in GenomicFeatures >= 1.61.1. Please call
  txdbmaker::makeTxDbFromGFF() to get rid of this error.

Yes, this seems to have changed in the current BioC devel version.

@ibn-salem
Copy link
Copy Markdown
Member

The makeTxDbFromGFF() issue has been fixed in the dev branch and these changes are now merged into this.

@ibn-salem
Copy link
Copy Markdown
Member

version is now 0.6.14

@ibn-salem ibn-salem marked this pull request as ready for review October 20, 2025 13:40
@ibn-salem ibn-salem merged commit fe3cc03 into dev Oct 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants