Merged
Conversation
fix spelling
fix docker syntax for dockerx build in github workflow
fix typo
Member
I think this should not be a problem. If I remember correctly, we required this for the old docker version on our system.
Name should be fine |
Member
|
@ibn-salem, can you please review the R-CMD check? I think this comes from the transition of the txdb function into a new R package |
Member
Yes, this seems to have changed in the current BioC devel version. |
Member
|
The |
Member
|
version is now 0.6.14 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I prepared a new workflow for building the docker image.
I tested it and it created the image https://github.com/TRON-Bioinformatics/splice2neo/pkgs/container/splice2neo with the current release v0.6.13 as tag. Can be pulled with the command:
docker pull ghcr.io/tron-bioinformatics/splice2neo:v0.6.13After testing I switched the trigger to release. The pipeline should now only run when a new release was published and the tag should always be the release tag.
@johausmann
❓I edited the syntax in the Dockerfile since docker buildx in github doesn't recognize the "docker://" prefix. Will this still work for your local build? When not, we need a second Dockerfile.
❓ Is "splice2neo" as name for the image ok or would something else be more suitable?