-
Notifications
You must be signed in to change notification settings - Fork 334
Support class versions #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jvandort
wants to merge
1
commit into
TNG:main
Choose a base branch
from
jvandort:jvandort/support-class-versions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+85
−0
Open
Support class versions #1418
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
61 changes: 61 additions & 0 deletions
61
archunit/src/main/java/com/tngtech/archunit/core/domain/JavaClassVersion.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| package com.tngtech.archunit.core.domain; | ||
|
|
||
| /** | ||
| * Represents the version of a JVM class file. | ||
| */ | ||
| public class JavaClassVersion { | ||
|
|
||
| private final int major; | ||
| private final int minor; | ||
|
|
||
| /** | ||
| * Create a new instance of {@link JavaClassVersion}. | ||
| * | ||
| * @param major The major version of the class file. | ||
| * @param minor The minor version of the class file. | ||
| */ | ||
| public JavaClassVersion(int major, int minor) { | ||
| this.major = major; | ||
| this.minor = minor; | ||
| } | ||
|
|
||
| /** | ||
| * Get the Java version corresponding to the major version of the class file. | ||
| * | ||
| * @return The Java version | ||
| */ | ||
| public int getJavaVersion() { | ||
| return major - 44; | ||
| } | ||
|
|
||
| /** | ||
| * Get the major version of the class file. | ||
| * | ||
| * @return The major version | ||
| */ | ||
| public int getBytecodeMajorVersion() { | ||
| return major; | ||
| } | ||
|
|
||
| /** | ||
| * Get the minor version of the class file. | ||
| * | ||
| * @return The minor version | ||
| */ | ||
| public int getBytecodeMinorVersion() { | ||
| return minor; | ||
| } | ||
|
|
||
| /** | ||
| * Create a new instance of {@link JavaClassVersion} from the version as provided by ASM. | ||
| * | ||
| * @return A representation of the class file version | ||
| */ | ||
| public static JavaClassVersion of(int asmVersion) { | ||
| int major = asmVersion & 0xFF; | ||
| int minor = asmVersion >> 16; | ||
|
|
||
| return new JavaClassVersion(major, minor); | ||
| } | ||
|
|
||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be a bit nitpicky:
Do you consider the version old java versions 1.0, 1.1, ... as 1, 1, 2?
https://javaalmanac.io/bytecode/versions/
Java 1.0 -> class file version 45.0 -> java version 1
Java 1.1 -> class file version 45.3 -> java version 1
Java 1.2 -> class file version 46.0 -> java version 2
...
starting from Java5 you calculation works perfectly fine, before that the numbering is already weird on java side.
Do we ignore this since these version are so ancient that we can't expect anyone to stumble over java classes compiled before java 5?
Since even Java 8 is currently dyng, this should be fine