Skip to content

Revert XKCP alignment sanitizer suppression #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koko1123 merged 1 commit into from
Mar 13, 2026
Merged

Revert XKCP alignment sanitizer suppression #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions build.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,11 +123,7 @@ pub fn build(b: *std.Build) void {

/// Add XKCP keccak C sources to a module with CPU-appropriate backend selection.
fn addXkcp(b: *std.Build, module: *std.Build.Module, target: std.Build.ResolvedTarget) void {
// XKCP's plain64 backend casts input data to uint64_t* without alignment
// guarantees (KeccakP1600_plain64_AddLanes). Disable alignment sanitizer to
// avoid UBSan traps in debug builds; unaligned u64 loads are fast on all
// modern targets (x86_64, aarch64).
const c_flags = &.{ "-O3", "-fno-sanitize=alignment" };
const c_flags = &.{"-O3"};

// Common include paths
module.addIncludePath(b.path("src/crypto/xkcp/common"));
Expand Down
Loading