fix: resolve memory leak by adding proper event listener and timer cl…#208
Open
sangjiexun wants to merge 1 commit intoStreamedian:masterfrom
Open
fix: resolve memory leak by adding proper event listener and timer cl…#208sangjiexun wants to merge 1 commit intoStreamedian:masterfrom
sangjiexun wants to merge 1 commit intoStreamedian:masterfrom
Conversation
…eanup - player.js: Store bound handlers and remove all event listeners in destroy() - base_client.js: Call stopStreamFlush() in destroy() to clear timers - mse.js: Remove sourceopen/sourceended/sourceclose listeners in destroy() - MSEBuffer: Add null check for sourceBuffer before removal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eanup
--------------------------------------------------------------------------------------