Make prover thread count and aggregated-proof buffer configurable.#2796
Merged
Make prover thread count and aggregated-proof buffer configurable.#2796
Conversation
d4a3ae8 to
e8bc2c6
Compare
bkolad
commented
Apr 30, 2026
bkolad
commented
Apr 30, 2026
theodorebugnet
approved these changes
Apr 30, 2026
Co-authored-by: Theodore Bugnet <24320578+theodorebugnet@users.noreply.github.com>
db8de28 to
dd88c25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the folloing changes:
prover_thread_count_override: Option<NonZero<usize>>toProofManagerConfig. WhenNone(default),prover_thread_count()keeps its previous value of2 * aggregated_proof_block_jump + 1; whenSome(n), the override is used directly.max_number_of_aggregated_proofs_in_memory: NonZero<usize>toProofManagerConfigand thread it throughstart_zk_workflow_in_background→ZkProofManager. This becomes the capacity of the intake → aggregator mpsc (previously hardcoded to 1),so operators can let more completed aggregation windows queue in memory before back-pressure stalls intake.
max_number_of_transitions_in_db & max_number_of_transitions_in_memorymax_number_of_aggregated_proofs_in_memory = 5in the example/demo TOMLs and test rollup builders, and bumpmax_number_of_transitions_in_db/_in_memoryaccordingly so the new validation passes.I have updatedCHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues