remove zkvmnetwork trait and networkproverservice#2795
Open
remove zkvmnetwork trait and networkproverservice#2795
Conversation
ross-weir
commented
Apr 30, 2026
| #[derive(Debug)] | ||
| pub(crate) struct PendingProverTasksMetric { | ||
| /// Number of proving tasks currently in flight. | ||
| pub pending_tasks_count: usize, |
Member
Author
There was a problem hiding this comment.
Will look into re-adding this
Member
Author
There was a problem hiding this comment.
This diff line is wrong.. the comment was on the submit_duration_ms metric not pending tasks
bkolad
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove
ZkvmNetworktrait in favour of a singleZkvmHosttraitRemove
NetworkProverServicein favour of the existingParallelProverServicewhich works well for network/cpu/mock proving out of the boxCHANGELOG.mdwith a new entry if my PR makes any breaking changes or fixes a bug. If my PR removes a feature or changes its behavior, I provide help for users on how to migrate to the new behavior.Cargo.tomlchanges before opening the PRs. (Are all new dependencies necessary? Is any module dependency leaked into the full-node (hint: it shouldn't)?)Linked Issues
Testing
Describe how these changes were tested. If you've added new features, have you added unit tests?
Docs
Describe where this code is documented. If it changes a documented interface, have the docs been updated?
Rendered docs are available at
https://sovlabs-ci-rustdoc-artifacts.us-east-1.amazonaws.com/<BRANCH_NAME>/index.html