Build: update Ecasound detection to use libecasoundc-config script#414
Open
alios wants to merge 1 commit intoSoundScapeRenderer:masterfrom
Open
Build: update Ecasound detection to use libecasoundc-config script#414alios wants to merge 1 commit intoSoundScapeRenderer:masterfrom
alios wants to merge 1 commit intoSoundScapeRenderer:masterfrom
Conversation
Author
|
The CI fails, but it looks like it is unrelated to my patch. It fails in the Step "Installing apt packages", with: This is also mentioned here: #413 (comment) |
mgeier
reviewed
Aug 20, 2025
Member
mgeier
left a comment
There was a problem hiding this comment.
Thanks for this PR, and sorry for my late response!
I have fixed the CI failures, can you please rebase your PR?
Comment on lines
+580
to
+586
| AC_MSG_CHECKING([for ecasoundc.h via libecasoundc-config]) | ||
| AC_CHECK_HEADER([ecasoundc.h], [have_ecasound=yes], [have_ecasound=no]) | ||
| AC_MSG_CHECKING([for eca-control-interface.h via libecasoundc-config]) | ||
| AC_CHECK_HEADER([eca-control-interface.h], , [have_ecasound=no]) | ||
| AC_MSG_CHECKING([for Ecasound library via libecasoundc-config]) | ||
| AC_SEARCH_LIBS([eci_init], [ecasoundc], , [have_ecasound=no]) | ||
| AC_MSG_RESULT([$have_ecasound]) |
Member
There was a problem hiding this comment.
Are those checks still necessary? Wouldn't libecasoundc-config fail if those files aren't there?
Suggested change
| AC_MSG_CHECKING([for ecasoundc.h via libecasoundc-config]) | |
| AC_CHECK_HEADER([ecasoundc.h], [have_ecasound=yes], [have_ecasound=no]) | |
| AC_MSG_CHECKING([for eca-control-interface.h via libecasoundc-config]) | |
| AC_CHECK_HEADER([eca-control-interface.h], , [have_ecasound=no]) | |
| AC_MSG_CHECKING([for Ecasound library via libecasoundc-config]) | |
| AC_SEARCH_LIBS([eci_init], [ecasoundc], , [have_ecasound=no]) | |
| AC_MSG_RESULT([$have_ecasound]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ecasound is configured by search a given list of prefix for essential files to derive
CPPFLAGS,LIBSandINCLUDE_DIRas there is no pkg-config support for it.A comment from configure.ac deocuments this
But on systems where things are installed in non default prefixes (f.e. nixos where everyhing is stored under
/nix) this does not work.Sollution
ecasound comes with a tool
libecasoundc-configwhich beaves exactly like pkg-config but as its own tool and not as a.pcfile.This PR changes the
configure.acand replaces the scripted search by utilizing that tool.Note
Have only tested this under linux x64 on nixos.