Fix reference offset in GUI and add 3D support for Polhemus tracker#358
Merged
mgeier merged 1 commit intoSoundScapeRenderer:masterfrom Jun 15, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #140.
I tested this for the binaural renderer, and I can confirm that this is now as we discussed it. As a byproduct, this PR enables 3D head tracking with Polhemus trackers.
But I'm not sure about the other renderers. Please test this. I have the feeling that this
https://github.com/JensAhrens/ssr/blob/dd1d54491184b9aad4b6d3e53e08c1caa049db97/src/gui/qopenglplotter.cpp#L456-L457
needs to be removed because it is already carried out here:
https://github.com/JensAhrens/ssr/blob/dd1d54491184b9aad4b6d3e53e08c1caa049db97/src/gui/qopenglplotter.cpp#L364-L368