fix(contribution): bloquer "Afficher les informations" sans CC sélectionnée

[maxgfr]

fix #7231

[revu-bot]

Overall Assessment

The PR correctly addresses issue #7231 by showing a validation error when the user clicks "Afficher les informations" without selecting a convention collective. The implementation is clean and the test coverage is solid. A few issues worth addressing:

File	Lines	Severity	Issue
ContributionGenericAgreementSearch.tsx	155–165	IMPORTANT	event.preventDefault() called after router.push() — dead code in the valid-agreement branch
ContributionGenericAgreementSearch.tsx	148–149	IMPORTANT	setShowMissingAgreementError(false) is redundant after the early-return guard
ContributionGenericAgreementSearch.tsx	133–145	MINOR	Error alert rendered above the button it describes — consider placing it after for better reading order
contributions.test.tsx	127–148	MINOR	New tests marked async but contain no await — misleading signature

[revu-bot]

[IMPORTANT] event.preventDefault() is unreachable dead code in the valid-agreement branch

• After the early-return guard on line 148 (if (!selectedAgreement) { … return; }), selectedAgreement is guaranteed to be truthy for the rest of the handler.
• Therefore the else { event.preventDefault() } branch (when isValid is false but selectedAgreement is set) is still reachable — but calling event.preventDefault() on a type="button" has no effect anyway, since buttons don't have a default browser action.
• More importantly, setShowMissingAgreementError(false) on line 149 is now redundant: the only way to reach it is when selectedAgreement is truthy, and the useEffect already resets the flag whenever selectedAgreement changes. Keeping it creates a false impression that it is needed here.

- setShowMissingAgreementError(false);
  onDisplayClick(isValid && !!selectedAgreement);
  if (isValid && selectedAgreement) {
    router.push(
      slug === "les-conges-pour-evenements-familiaux"
        ? `/contribution/${slug}/${selectedAgreement?.slug || selectedAgreement?.num}`
        : `/contribution/${selectedAgreement?.num}-${slug}`
    );
- } else {
-   event.preventDefault();
  }

Suggested clean-up:

[revu-bot]

[IMPORTANT] Error alert is rendered above the button it describes — reading order concern

• Screen readers and keyboard users encounter the error message before the button that triggered it. This is counter-intuitive: the user activates the button, then has to scroll/tab back up to read the error.
• DSFR convention for inline form errors is to place the alert immediately after the triggering control, not before it.
• Moving the <AccessibleAlert> below the <Button> keeps the DOM order consistent with the visual interaction flow and improves the experience for assistive-technology users.

Suggested change

	{showMissingAgreementError && (
	<AccessibleAlert
	title="Veuillez sélectionner une convention collective"
	description={
	<p>
	Pour afficher des informations personnalisées, vous devez
	d’abord sélectionner une convention collective. Si vous ne
	souhaitez pas en sélectionner, vous pouvez cliquer sur
	«&nbsp;Afficher les informations sans sélectionner une
	convention collective&nbsp;» ci-dessous.
	</p>
	}
	severity="error"
	<Button
	className={fr.cx("fr-mt-2w")}
	type="button"
	onClick={(event) => {
	if (!selectedAgreement) {
	event.preventDefault();
	setShowMissingAgreementError(true);
	return;
	}
	onDisplayClick(isValid && !!selectedAgreement);
	if (isValid) {
	router.push(
	slug === "les-conges-pour-evenements-familiaux"
	? `/contribution/${slug}/${selectedAgreement.slug || selectedAgreement.num}`
	: `/contribution/${selectedAgreement.num}-${slug}`
	);
	}
	}}
	>
	Afficher les informations
	</Button>
	{showMissingAgreementError && (
	<AccessibleAlert
	title="Veuillez sélectionner une convention collective"
	description={
	<p>
	Pour afficher des informations personnalisées, vous devez
	d'abord sélectionner une convention collective. Si vous ne
	souhaitez pas en sélectionner, vous pouvez cliquer sur
	«&nbsp;Afficher les informations sans sélectionner une
	convention collective&nbsp;» ci-dessous.
	</p>
	}
	severity="error"
	className={["fr-mt-2w"]}
	data-testid="missing-agreement-error"
	/>
	)}

[revu-bot]

[MINOR] New tests are declared async but contain no await — misleading signature

• async functions that never await anything are functionally synchronous. This is misleading to future maintainers who may assume there is asynchronous work happening.
• Either remove async from the two purely synchronous tests, or add the missing await if async assertions were intended.

Affected tests:

• "should display an error and not navigate when clicking 'Afficher les informations' without selecting any agreement" (line 127)
• "should still allow displaying generic content via the fallback link when no agreement is selected" (line 163)

Suggested change

	it("should display an error and not navigate when clicking 'Afficher les informations' without selecting any agreement", async () => {
	it("should display an error and not navigate when clicking 'Afficher les informations' without selecting any agreement", () => {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tokenbureau]

🎉 Deployment for commit 8ef96d7 :

Ingresses

• 🚀 https://code-du-travail-numerique-maxgfr-afficher-les-informa-59vmj3vz.ovh.fabrique.social.gouv.fr/

Docker images

• 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/code-du-travail-numerique/app:sha-8ef96d7699277fe1f3acc7d7f31caac5c8ec3335

Debug

• 📕 Loki logs for namespace code-du-travail-numerique-maxgfr-afficher-les-informa-59vmj3vz
• 📈 Pods monitoring for namespace code-du-travail-numerique-maxgfr-afficher-les-informa-59vmj3vz
• 📈 Workloads monitoring for namespace code-du-travail-numerique-maxgfr-afficher-les-informa-59vmj3vz