fix(search): fake commit to trigger linked deployment

[rmelisson]

No description provided.

[revu-bot]

Review Summary

This PR contains two changes: a default parameter bump (size: 5 → 8) and a debug console.log left in production code. The PR title ("fake commit to trigger linked deployment") is itself a red flag — it signals the change was not made for a legitimate functional reason.

File	Lines	Severity	Issue
src/api/modules/suggest/service.ts	14	CRITICAL	console.log debug statement left in production code
src/api/modules/suggest/service.ts	6	IMPORTANT	Undocumented/unjustified default size change (5 → 8)

[revu-bot]

[CRITICAL] Debug console.log must not reach production

• Why it matters: This logs the full Elasticsearch query body on every suggestion request. In production this will:
  • Flood server logs with high-volume noise (one log per keystroke per user).
  • Potentially expose internal query structure / index configuration in log aggregation systems.
  • Degrade performance under load due to JSON.stringify on every call.
• Fix: Remove the statement entirely before merging.

Suggested change

	console.log(JSON.stringify(body, null, 2));
	return response.hits.hits.map((t) => t._source.title);
	return response.hits.hits.map((t) => t._source.title);

[revu-bot]

[IMPORTANT] Undocumented change to default size (5 → 8)

• Why it matters: The default suggestion count is a product/UX decision that affects perceived search quality and Elasticsearch load. Changing it silently (and in a commit explicitly described as a "fake commit") makes it impossible to audit or revert intentionally.
• Actions required:
  1. If this change is intentional, document the rationale in a code comment or PR description and add/update tests that assert the new default.
  2. If it was accidental, revert to 5.

Suggested change

	export const getSuggestions = async (q: string, size = 8) => {
	export const getSuggestions = async (q: string, size = 5) => {

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tokenbureau]

🎉 Deployment for commit fe7b84b :

Ingresses

• 🚀 https://code-du-travail-numerique-linked-suggestions.ovh.fabrique.social.gouv.fr/

Docker images

• 📦 docker pull harbor.fabrique.social.gouv.fr/cdtn/code-du-travail-numerique/app:sha-fe7b84b04f4fe7b9306982af8775136165e4a605

Debug

• 📕 Loki logs for namespace code-du-travail-numerique-linked-suggestions
• 📈 Pods monitoring for namespace code-du-travail-numerique-linked-suggestions
• 📈 Workloads monitoring for namespace code-du-travail-numerique-linked-suggestions