fix(sentry): correction des erreurs remontées par Sentry#7225
fix(sentry): correction des erreurs remontées par Sentry#7225
Conversation
m-maillot
commented
Apr 8, 2026
m-maillot
commented
- Suppression du Sentry.captureMessage sur les pages 404 (bruit inutile)
- Remplacement des IDs non-déterministes (uuid, Math.random) par des IDs stables pour corriger les erreurs d'hydration React
- Ajout d'un auto-reload sur ChunkLoadError pour gérer les anciens chunks après redéploiement
- Amélioration du reporting d'erreur du simulateur d'embauche avec captureException et contexte
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
| }; | ||
|
|
||
| export default function Index() { | ||
| Sentry.captureMessage("Page non trouvée"); |
There was a problem hiding this comment.
Les 404 n'ont pas vocation a être récupéré dans Sentry. D'autant plus qu'on ne sait pas les analyser tellement il y en a.
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Review: fix(sentry) — Sentry noise reduction & hydration fixes
This PR addresses several legitimate issues: removing noisy 404 Sentry messages, fixing React hydration errors from non-deterministic IDs, adding ChunkLoadError auto-reload, and improving error reporting in the hiring simulator. The overall direction is correct, but there are a few issues worth addressing.
| File | Lines | Severity | Issue |
|---|---|---|---|
app/error.tsx |
22–24 | CRITICAL | Infinite reload loop on persistent ChunkLoadError |
app/error.tsx |
15–19 | MINOR | reset prop accepted but never used |
src/modules/common/DisplayContent.tsx |
48–55 | IMPORTANT | Index-based IDs break accordion stability on reorder/filter |
src/modules/outils/simulateur-embauche/HiringSimulator.tsx |
42–46 | IMPORTANT | event: String(event) may truncate useful event data |
| ...(isParent | ||
| ? { id: slugify(item.title) } | ||
| : { id: slugify(item.title) + "_" + generateUUID() }), | ||
| : { id: slugify(item.title) + "_" + index }), |
There was a problem hiding this comment.
Ca c'est à vérifier ! Car on avait pas mal de soucis sur les accordéons ! Je vais passer sur les écrans qui posaient soucis.
m-maillot
force-pushed
the
fix/sentry-issues
branch
from
086cf79 to
ac1f290
Compare
m-maillot
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
m-maillot
force-pushed
the
fix/sentry-issues
branch
from
ac1f290 to
357f142
Compare
m-maillot
had a problem deploying
to
build-review-auto
GitHub Actions
Error
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
- Suppression du Sentry.captureMessage sur les pages 404 (bruit inutile) - Remplacement des IDs non-déterministes (uuid, Math.random) par des IDs stables pour corriger les erreurs d'hydration React - Ajout d'un auto-reload sur ChunkLoadError pour gérer les anciens chunks après redéploiement - Amélioration du reporting d'erreur du simulateur d'embauche avec captureException et contexte Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
m-maillot
force-pushed
the
fix/sentry-issues
branch
from
357f142 to
5eb0d98
Compare
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
m-maillot
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
|
|
🎉 Deployment for commit 5eb0d98 : IngressesDocker images
|
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Review: fix(sentry) — Sentry noise reduction & hydration fixes
This PR addresses several legitimate Sentry issues: removing noisy 404 captures, fixing hydration mismatches from non-deterministic IDs, adding a ChunkLoadError auto-reload guard, and improving error context in the hiring simulator. The overall direction is correct, but there are a few issues worth addressing.
| File | Lines | Severity | Issue |
|---|---|---|---|
app/error.tsx |
22–30 | CRITICAL | reset prop accepted but never used; ChunkLoadError reload shows error UI before reloading |
app/error.tsx |
22–30 | IMPORTANT | sessionStorage access not guarded against SSR/private-browsing errors |
src/modules/common/DisplayContent.tsx |
52–57 | IMPORTANT | Index-based IDs break accordion identity on reorder/filter |
src/modules/outils/simulateur-embauche/HiringSimulator.tsx |
42–47 | MINOR | event: String(event) may truncate useful Event object data |
maxgfr
left a comment
maxgfr
left a comment
There was a problem hiding this comment.
Nice le skill :)
Actuellement, il n'y a pas d'alternative concernant le fait d'avoir un folder lié à Claude Code avec un .claude :(
| if (error.name === "ChunkLoadError") { | ||
| const key = `chunk-reload:${error.message}`; | ||
| if (!sessionStorage.getItem(key)) { | ||
| sessionStorage.setItem(key, "1"); | ||
| window.location.reload(); | ||
| return; | ||
| } | ||
| } |
There was a problem hiding this comment.
C'est spécifique comme fix cela ?
3 participants
