Open
Conversation
m-maillot
had a problem deploying
to
build-preproduction
GitHub Actions
Failure
revu-bot
reviewed
Apr 8, 2026
Collaborator
revu-bot
left a comment
revu-bot
left a comment
There was a problem hiding this comment.
PR Summary: Remove Pre-qualified Results
This PR removes the "pre-qualified" (PQ) results feature from search by setting withPQ = false across the codebase. The changes are minimal and focused.
| File | Lines | Severity | Issue |
|---|---|---|---|
src/modules/recherche/query.ts |
7–9 | IMPORTANT | withPQ parameter is misleading — default false makes the param vestigial |
src/api/modules/search/controller.ts |
14–16 | IMPORTANT | presearch() method is now a dead method — get() is never defined |
app/recherche/page.tsx |
42 | MINOR | Hardcoded 25 duplicates the default already set in query.ts |
Overall: The core intent (disabling PQ) is correctly applied. However, there are a few maintainability concerns worth addressing before merging.
m-maillot
force-pushed
the
persist/remi/search-nopq
branch
from
727a03d to
287e1d3
Compare
m-maillot
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
m-maillot
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
devthejo
temporarily deployed
to
build-review-auto
GitHub Actions
Inactive
devthejo
temporarily deployed
to
build-preproduction
GitHub Actions
Inactive
|
|
🎉 Deployment for commit 6563245 : IngressesDocker images
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.