Add version consistency check#491
Add version consistency check#491PrincessStevenson (PrincessStevenson) wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a dedicated GitHub Actions workflow to run Skyscanner/version-consistency-check@v1 so language version mismatches are surfaced as a distinct PR check and fail builds when inconsistencies are found.
Changes:
- Introduces a new
Version Consistency Checkworkflow triggered on PRs targetingmainand pushes tomain. - Runs
Skyscanner/version-consistency-check@v1withfail-on-inconsistency: true.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| contents: read | ||
| runs-on: ubuntu-latest-small | ||
| steps: | ||
| - uses: actions/checkout@v6 |
There was a problem hiding this comment.
actions/checkout@v6 is inconsistent with the rest of the repo (other workflows use actions/checkout@v4), and may not be a valid major tag for the checkout action in this repository’s dependency policy. Suggest switching this to actions/checkout@v4 for consistency (or pin to whatever version is used elsewhere).
| - uses: actions/checkout@v6 | |
| - uses: actions/checkout@v4 |
| name: Version Consistency Check | ||
| permissions: | ||
| contents: read | ||
| runs-on: ubuntu-latest-small |
There was a problem hiding this comment.
runs-on: ubuntu-latest-small is not a standard GitHub-hosted runner label (the repo’s other workflows use ubuntu-latest). If this repository/org doesn’t provide a runner with that label, this workflow will never start. Recommend using ubuntu-latest (or an existing, documented self-hosted runner label used in this repo).
| runs-on: ubuntu-latest-small | |
| runs-on: ubuntu-latest |
|
Closing this rollout PR because we should not use the internal version-consistency-check action in public repos. |
What
This PR adds a standalone
Version Consistency Checkworkflow to the repository.It runs Skyscanner/version-consistency-check@v1 as a separate check in GitHub so version mismatches show up clearly on the PR.
The check is configured to fail when inconsistencies are found.
Why
This introduces language version mismatch checks in the repository.
It is part of the strategic action for INL-3290 /
INC-4850and is outlined in COMET-2757.The check looks for mismatched build and runtime language versions across repository configuration, workflow setup, and Dockerfiles where supported.
References
action.ymlTesting
Not run locally. Workflow change only.
Request
As the owning squad, please review and merge.
This PR was generated using turbolift.