Honor cache control directives for timestamp cache#362
Merged
SimonCropp merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
Respect Cache-Control when serving cached timestamps: skip cache on "no-cache", use the request Cache-Control values when parsing staleness, and compute elapsed time earlier for accurate comparisons. Add helpers HasDirective and TryParseDirectiveValue to inspect StringValues for directives (e.g. min-fresh) and ensure min-fresh + elapsed does not exceed max-age before returning a cached timestamp. Minor refactor to improve clarity and correctness of cache validation.
SimonCropp
deleted the
Honor-Cache-Control-directives-for-timestamp-cache
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.