Merged
Conversation
Move the pending promises list from AudioContext to BaseAudioContext and deal with all remaining FIXMEs. (cherry picked from commit 2df3488)
Fixes a crash seen on twitter.com, namely from the 'resume' function. (cherry picked from commit 5d7a7a4)
Previously, the inclusive descendant, which is the node that for_each_shadow_including_inclusive_descendant was called on, would not have it's shadow root traversed if it had one. This is because the shadow root traversal was in the `for` loop, which begins with the node's first child. The fix here is to move the shadow root traversal outside of the loop, and check if the current node is an element instead. (cherry picked from commit 6df4e5f)
The insertion steps for iframes were following an old version of the spec, where it was checking if the iframe was "in a document tree", which doesn't cross shadow root boundaries. The spec has since been updated to check the shadow including root instead. This is now needed for Cloudflare Turnstile iframe widgets to appear, as they are now inserted into a shadow root. (cherry picked from commit 4dd14d8)
(cherry picked from commit 213155a)
A recently imported WPT test has a subtest that effectively does the
following:
const mql = window.matchMedia("");
mql.removeListener(null);
(cherry picked from commit 3e5476c)
github-actions
bot
added
the
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LadybirdBrowser/ladybird#1839
LadybirdBrowser/ladybird#1991
LadybirdBrowser/ladybird#2310
LadybirdBrowser/ladybird#2313