Skip to content

Add pseudo tables #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Huliiiiii wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add pseudo tables #987

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9db7a2f
Add pseudo tables
Huliiiiii Sep 1, 2025
7247472
Tweak
Huliiiiii Sep 2, 2025
0941155
Fix
Huliiiiii Sep 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions src/backend/query_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,6 +657,19 @@ pub trait QueryBuilder:
}
sql.write_str("*").unwrap();
}
ColumnRef::New(column) => {
sql.write_str("NEW.").unwrap();
self.prepare_iden(column, sql);
}
ColumnRef::Old(column) => {
sql.write_str("OLD.").unwrap();
self.prepare_iden(column, sql);
}
#[cfg(feature = "backend-postgres")]
ColumnRef::Excluded(column) => {
sql.write_str("excluded.").unwrap();
self.prepare_iden(column, sql);
}
}
}

Expand Down
11 changes: 11 additions & 0 deletions src/types/iden/compound.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,13 @@ pub enum ColumnRef {
Column(ColumnName),
/// An `*` expression, potentially qualified as `(database.)(schema.)(table.)*`.
Asterisk(Option<TableName>),
/// NEW.*
New(DynIden),
/// Old.*
Old(DynIden),
#[cfg(feature = "backend-postgres")]
/// excluded.*
Excluded(DynIden),
Copy link
Member

@Expurple Expurple Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To we really need these special variants? These table names look like they can be already expressed as "regular" table names: ColumnRef::from(("OLD", MyColumn))

It may be enough to define some unit-struct idens for these tables and document the approach.

Copy link
Member Author

@Huliiiiii Huliiiiii Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prepare_iden will quote them, but they cannot be quoted.

Copy link
Member

@Expurple Expurple Sep 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see. Then, I wouldn't change ColumnRef at all. We don't need to do anything with the "column basename" part. We need to somehow allow unquoted TableNames (which would then be stored in ColumnRef as usual) and provide a way to construct unquoted TableNames ergonomically

}

impl ColumnRef {
Expand All @@ -144,6 +151,10 @@ impl ColumnRef {
match self {
ColumnRef::Column(ColumnName(_table_ref, column_itself)) => Some(column_itself),
ColumnRef::Asterisk(..) => None,
ColumnRef::New(column_itself) => Some(column_itself),
ColumnRef::Old(column_itself) => Some(column_itself),
#[cfg(feature = "backend-postgres")]
ColumnRef::Excluded(column_itself) => Some(column_itself),
}
}
}
Expand Down
Loading