Add support for postgres advisory locks#1062
Open
NeelChotai wants to merge 3 commits intoSeaQL:masterfrom
Open
Add support for postgres advisory locks#1062NeelChotai wants to merge 3 commits intoSeaQL:masterfrom
NeelChotai wants to merge 3 commits intoSeaQL:masterfrom
Conversation
Huliiiiii
approved these changes
Mar 23, 2026
Member
|
I did some refactor in #1063. Now FunctionCall::new accepts Into, so you can simplify the code a bit. |
608ad6e to
a94d502
Compare
Author
updated! |
b731a0e to
66745a3
Compare
Member
|
You can just use |
Huliiiiii
reviewed
Mar 23, 2026
66745a3 to
50f4e77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Info
This PR adds support for Postgres advisory locks: https://www.postgresql.org/docs/current/explicit-locking.html#ADVISORY-LOCKS
I was considering just adding one
advisory_lockfunction, and instead having:However this felt a bit messy, and breaking with current conventions.
New Features
Bug Fixes
Breaking Changes
Changes