Skip to content

Add support for time::UtcDateTime#1058

Open
strwbrr-fox wants to merge 1 commit intoSeaQL:utc-timefrom
strwbrr-fox:with-time
Open

Add support for time::UtcDateTime#1058
strwbrr-fox wants to merge 1 commit intoSeaQL:utc-timefrom
strwbrr-fox:with-time

Conversation

@strwbrr-fox
Copy link

PR Info

  • Closes
  • Dependencies:
  • Dependents:

New Features

  • Support for time::UtcDateTime

Bug Fixes

Breaking Changes

Changes

  • Introduced TimeDateTimeUtc variant in Value and ArrayType enums.
  • Updated sqlx integration files (MySQL, Postgres, SQLite) to handle TimeDateTimeUtc.
  • Enhanced serialization and deserialization for TimeDateTimeUtc.
  • Added necessary trait implementations for UtcDateTime.
  • Updated query builder and JSON conversion functions to accommodate new type.

- Introduced `TimeDateTimeUtc` variant in `Value` and `ArrayType` enums.
- Updated `sqlx` integration files (MySQL, Postgres, SQLite) to handle `TimeDateTimeUtc`.
- Enhanced serialization and deserialization for `TimeDateTimeUtc`.
- Added necessary trait implementations for `UtcDateTime`.
- Updated query builder and JSON conversion functions to accommodate new type.
@strwbrr-fox
Copy link
Author

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to rename this to TimeUtcDateTime?

Copy link
Author

@strwbrr-fox strwbrr-fox Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using the same pattern as for Value::ChronoDateTimeUtc to be symmetrical

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but we named it that way because in chrono, that’s Datetime<Utc>.

What do you think? @tyt2y3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TimeUtcDateTime seems more consistent with time::UtcDateTime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants